Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1865003003: perf: Reenable oort online perf tests. (Closed)

Created:
4 years, 8 months ago by dmurph
Modified:
4 years, 8 months ago
Reviewers:
Sami, petrcermak
CC:
chromium-reviews, telemetry-reviews_chromium.org, kinuko, michaeln, ojan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

perf: Reenable oort online perf tests. I believe crrev.com/1853333003 fixed the issue, but if not then crrev.com/1846363002 should produce better error reporting. BUG=599416 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Committed: https://crrev.com/2eef5966da78bb5b98dffc941f69d8877c8fcd41 Cr-Commit-Position: refs/heads/master@{#385804}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tools/perf/benchmarks/oortonline.py View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
dmurph
4 years, 8 months ago (2016-04-06 21:50:07 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865003003/1
4 years, 8 months ago (2016-04-06 21:51:15 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-06 23:50:34 UTC) #7
dmurph
+petrcermak
4 years, 8 months ago (2016-04-07 00:13:01 UTC) #9
Sami
lgtm, thanks.
4 years, 8 months ago (2016-04-07 09:44:07 UTC) #10
petrcermak
+cc reviewers of the fix (https://codereview.chromium.org/1853333003) LGTM! Thanks, Petr
4 years, 8 months ago (2016-04-07 12:57:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865003003/1
4 years, 8 months ago (2016-04-07 17:37:08 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 17:56:26 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 17:58:31 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2eef5966da78bb5b98dffc941f69d8877c8fcd41
Cr-Commit-Position: refs/heads/master@{#385804}

Powered by Google App Engine
This is Rietveld 408576698