pkg/barback/lib/src/transformer.dart - Issue 18650004: Make Assets know their ID. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(359)

My Issues | Starred Open | Closed | All

Unified Diff: pkg/barback/lib/src/transformer.dart

Issue 18650004: Make Assets know their ID. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« pkg/barback/lib/src/transform.dart ('K') | « pkg/barback/lib/src/transform_node.dart ('k') | pkg/barback/test/asset_id_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/barback/lib/src/transformer.dart

diff --git a/pkg/barback/lib/src/transformer.dart b/pkg/barback/lib/src/transformer.dart

index 664d2e4c7fe1e202fbfda06588f466acce1d89ae..422066f1e4f373dfab5cb9c9612638a9fd2fb9a9 100644

--- a/pkg/barback/lib/src/transformer.dart

+++ b/pkg/barback/lib/src/transformer.dart

@@ -7,7 +7,7 @@ library barback.transformer;

import 'dart:async';

import 'dart:io';

-import 'asset_id.dart';

+import 'asset.dart';

import 'transform.dart';

/// A [Transformer] represents a processor that takes in one or more input

@@ -29,7 +29,7 @@ abstract class Transformer {

/// of those to generate the final JS. However you still run dart2js "on" a

/// single file: the entrypoint Dart file that has your `main()` method.

/// This entrypoint file would be the primary input.

- Future<bool> isPrimary(AssetId input);

+ Future<bool> isPrimary(Asset input);

/// Run this transformer on on the primary input specified by [transform].

///

« pkg/barback/lib/src/transform.dart ('K') | « pkg/barback/lib/src/transform_node.dart ('k') | pkg/barback/test/asset_id_test.dart » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698