Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Side by Side Diff: src/x64/full-codegen-x64.cc

Issue 18650003: Revert "Convert UnaryOpStub to a HydrogenCodeStub" (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4335 matching lines...) Expand 10 before | Expand all | Expand 10 after
4346 default: 4346 default:
4347 UNREACHABLE(); 4347 UNREACHABLE();
4348 } 4348 }
4349 } 4349 }
4350 4350
4351 4351
4352 void FullCodeGenerator::EmitUnaryOperation(UnaryOperation* expr, 4352 void FullCodeGenerator::EmitUnaryOperation(UnaryOperation* expr,
4353 const char* comment) { 4353 const char* comment) {
4354 // TODO(svenpanne): Allowing format strings in Comment would be nice here... 4354 // TODO(svenpanne): Allowing format strings in Comment would be nice here...
4355 Comment cmt(masm_, comment); 4355 Comment cmt(masm_, comment);
4356 UnaryOpStub stub(expr->op()); 4356 bool can_overwrite = expr->expression()->ResultOverwriteAllowed();
4357 UnaryOverwriteMode overwrite =
4358 can_overwrite ? UNARY_OVERWRITE : UNARY_NO_OVERWRITE;
4359 UnaryOpStub stub(expr->op(), overwrite);
4357 // UnaryOpStub expects the argument to be in the 4360 // UnaryOpStub expects the argument to be in the
4358 // accumulator register rax. 4361 // accumulator register rax.
4359 VisitForAccumulatorValue(expr->expression()); 4362 VisitForAccumulatorValue(expr->expression());
4360 SetSourcePosition(expr->position()); 4363 SetSourcePosition(expr->position());
4361 CallIC(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, 4364 CallIC(stub.GetCode(isolate()), RelocInfo::CODE_TARGET,
4362 expr->UnaryOperationFeedbackId()); 4365 expr->UnaryOperationFeedbackId());
4363 context()->Plug(rax); 4366 context()->Plug(rax);
4364 } 4367 }
4365 4368
4366 4369
(...skipping 536 matching lines...) Expand 10 before | Expand all | Expand 10 after
4903 *context_length = 0; 4906 *context_length = 0;
4904 return previous_; 4907 return previous_;
4905 } 4908 }
4906 4909
4907 4910
4908 #undef __ 4911 #undef __
4909 4912
4910 } } // namespace v8::internal 4913 } } // namespace v8::internal
4911 4914
4912 #endif // V8_TARGET_ARCH_X64 4915 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698