Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 18650003: Revert "Convert UnaryOpStub to a HydrogenCodeStub" (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/lithium-arm.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4348 matching lines...) Expand 10 before | Expand all | Expand 10 after
4359 default: 4359 default:
4360 UNREACHABLE(); 4360 UNREACHABLE();
4361 } 4361 }
4362 } 4362 }
4363 4363
4364 4364
4365 void FullCodeGenerator::EmitUnaryOperation(UnaryOperation* expr, 4365 void FullCodeGenerator::EmitUnaryOperation(UnaryOperation* expr,
4366 const char* comment) { 4366 const char* comment) {
4367 // TODO(svenpanne): Allowing format strings in Comment would be nice here... 4367 // TODO(svenpanne): Allowing format strings in Comment would be nice here...
4368 Comment cmt(masm_, comment); 4368 Comment cmt(masm_, comment);
4369 UnaryOpStub stub(expr->op()); 4369 bool can_overwrite = expr->expression()->ResultOverwriteAllowed();
4370 UnaryOverwriteMode overwrite =
4371 can_overwrite ? UNARY_OVERWRITE : UNARY_NO_OVERWRITE;
4372 UnaryOpStub stub(expr->op(), overwrite);
4370 // UnaryOpStub expects the argument to be in the 4373 // UnaryOpStub expects the argument to be in the
4371 // accumulator register r0. 4374 // accumulator register r0.
4372 VisitForAccumulatorValue(expr->expression()); 4375 VisitForAccumulatorValue(expr->expression());
4373 SetSourcePosition(expr->position()); 4376 SetSourcePosition(expr->position());
4374 CallIC(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, 4377 CallIC(stub.GetCode(isolate()), RelocInfo::CODE_TARGET,
4375 expr->UnaryOperationFeedbackId()); 4378 expr->UnaryOperationFeedbackId());
4376 context()->Plug(r0); 4379 context()->Plug(r0);
4377 } 4380 }
4378 4381
4379 4382
(...skipping 532 matching lines...) Expand 10 before | Expand all | Expand 10 after
4912 *context_length = 0; 4915 *context_length = 0;
4913 return previous_; 4916 return previous_;
4914 } 4917 }
4915 4918
4916 4919
4917 #undef __ 4920 #undef __
4918 4921
4919 } } // namespace v8::internal 4922 } } // namespace v8::internal
4920 4923
4921 #endif // V8_TARGET_ARCH_ARM 4924 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/lithium-arm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698