Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18650003: Revert "Convert UnaryOpStub to a HydrogenCodeStub" (Closed)

Created:
7 years, 5 months ago by oliv
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Revert "Convert UnaryOpStub to a HydrogenCodeStub" The problem is the HCallConstantFunction which is not context sensitive, so we leak the builtin. We first need a Hydrogen version of __ IvokeBuiltin. BUG= R=danno@chromium.org, machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15486

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1336 lines, -613 lines) Patch
M src/arm/code-stubs-arm.h View 1 chunk +65 lines, -0 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 2 chunks +271 lines, -12 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/arm/lithium-arm.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +2 lines, -21 lines 0 comments Download
M src/code-stubs.h View 11 chunks +13 lines, -84 lines 0 comments Download
M src/code-stubs.cc View 7 chunks +32 lines, -114 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M src/hydrogen.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/hydrogen.cc View 10 chunks +55 lines, -56 lines 0 comments Download
M src/hydrogen-instructions.h View 3 chunks +0 lines, -45 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 1 chunk +74 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +319 lines, -11 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 3 chunks +2 lines, -31 lines 0 comments Download
M src/ia32/lithium-ia32.h View 4 chunks +0 lines, -27 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +1 line, -23 lines 0 comments Download
M src/ic.h View 3 chunks +22 lines, -3 lines 0 comments Download
M src/ic.cc View 4 chunks +130 lines, -15 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/objects.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M src/property-details.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/type-info.cc View 2 chunks +2 lines, -13 lines 0 comments Download
M src/types.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/x64/code-stubs-x64.h View 1 chunk +71 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +254 lines, -12 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +2 lines, -21 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
oliv
7 years, 5 months ago (2013-07-03 18:09:02 UTC) #1
Michael Achenbach
lgtm
7 years, 5 months ago (2013-07-03 19:38:50 UTC) #2
danno
lgtm
7 years, 5 months ago (2013-07-03 19:46:33 UTC) #3
oliv
7 years, 5 months ago (2013-07-03 19:57:43 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r15486 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698