Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1864973005: Move remaining xfa/include/fxfa files (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move remaining xfa/include/fxfa files This CL moves the remaining files in xfa/include/fxfa to xfa/fxfa/include. Committed: https://pdfium.googlesource.com/pdfium/+/7222ea6936cbcff886037e4d8d4018e13a7f720f

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -2985 lines) Patch
M BUILD.gn View 1 2 2 chunks +13 lines, -13 lines 0 comments Download
M fpdfsdk/DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/fpdfsave.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_app.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_page.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfxfa/include/fpdfxfa_app.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/fsdk_annothandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fsdk_baseform.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fsdk_mgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fsdk_annothandler.h View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/include/fsdk_baseform.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M xfa.gyp View 1 2 1 chunk +13 lines, -13 lines 0 comments Download
M xfa/fwl/basewidget/fwl_editimp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_checksum.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffapp.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/fxfa/app/xfa_ffbarcode.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffbarcode.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffcheckbutton.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffcheckbutton.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/fxfa/app/xfa_ffchoicelist.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffchoicelist.cpp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdoc.cpp View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdochandler.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdocview.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdraw.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdraw.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffexclgroup.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffexclgroup.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_fffield.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_fffield.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/fxfa/app/xfa_ffimage.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffimageedit.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffnotify.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/fxfa/app/xfa_ffpageview.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffpath.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffpushbutton.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_ffsignature.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_ffsubform.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffsubform.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_fftext.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_fftextedit.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidget.cpp View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidgetacc.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidgethandler.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_fontmgr.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_fwladapter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fwltheme.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fwltheme.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_rendercontext.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_textlayout.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_textlayout.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + xfa/fxfa/include/DEPS View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + xfa/fxfa/include/fxfa.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + xfa/fxfa/include/fxfa_basic.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + xfa/fxfa/include/fxfa_widget.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + xfa/fxfa/include/xfa_checksum.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/fxfa/include/xfa_ffapp.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + xfa/fxfa/include/xfa_ffdoc.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/fxfa/include/xfa_ffdochandler.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/fxfa/include/xfa_ffdocview.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/fxfa/include/xfa_ffpageview.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + xfa/fxfa/include/xfa_ffwidget.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/fxfa/include/xfa_ffwidgethandler.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/fxfa/include/xfa_fontmgr.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/fxfa/include/xfa_rendercontext.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxfa/parser/cxfa_data.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_stroke.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_widgetdata.cpp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/parser/xfa_basic_data.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_basic_imp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_parser_imp.cpp View 2 chunks +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_eventpseudomodel.cpp View 2 chunks +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_utils.h View 1 chunk +1 line, -1 line 0 comments Download
D xfa/include/fxfa/fxfa.h View 1 chunk +0 lines, -555 lines 0 comments Download
D xfa/include/fxfa/fxfa_basic.h View 1 chunk +0 lines, -1079 lines 0 comments Download
D xfa/include/fxfa/fxfa_widget.h View 1 chunk +0 lines, -128 lines 0 comments Download
D xfa/include/fxfa/xfa_checksum.h View 1 chunk +0 lines, -74 lines 0 comments Download
D xfa/include/fxfa/xfa_ffapp.h View 1 chunk +0 lines, -78 lines 0 comments Download
D xfa/include/fxfa/xfa_ffdoc.h View 1 chunk +0 lines, -65 lines 0 comments Download
D xfa/include/fxfa/xfa_ffdochandler.h View 1 chunk +0 lines, -31 lines 0 comments Download
D xfa/include/fxfa/xfa_ffdocview.h View 1 chunk +0 lines, -172 lines 0 comments Download
D xfa/include/fxfa/xfa_ffpageview.h View 1 chunk +0 lines, -113 lines 0 comments Download
D xfa/include/fxfa/xfa_ffwidget.h View 1 2 1 chunk +0 lines, -182 lines 0 comments Download
D xfa/include/fxfa/xfa_ffwidgethandler.h View 1 chunk +0 lines, -127 lines 0 comments Download
D xfa/include/fxfa/xfa_fontmgr.h View 1 chunk +0 lines, -99 lines 0 comments Download
D xfa/include/fxfa/xfa_rendercontext.h View 1 chunk +0 lines, -36 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-04-06 18:11:49 UTC) #2
Tom Sepez
Spot inspection found sort order items. https://codereview.chromium.org/1864973005/diff/1/xfa/fxfa/include/xfa_ffdoc.h File xfa/fxfa/include/xfa_ffdoc.h (right): https://codereview.chromium.org/1864973005/diff/1/xfa/fxfa/include/xfa_ffdoc.h#newcode11 xfa/fxfa/include/xfa_ffdoc.h:11: #include "xfa/fxfa/include/fxfa.h" order.
4 years, 8 months ago (2016-04-06 19:10:07 UTC) #3
dsinclair
https://codereview.chromium.org/1864973005/diff/1/xfa/fxfa/include/xfa_ffdoc.h File xfa/fxfa/include/xfa_ffdoc.h (right): https://codereview.chromium.org/1864973005/diff/1/xfa/fxfa/include/xfa_ffdoc.h#newcode11 xfa/fxfa/include/xfa_ffdoc.h:11: #include "xfa/fxfa/include/fxfa.h" On 2016/04/06 19:10:07, Tom Sepez wrote: > ...
4 years, 8 months ago (2016-04-06 19:24:46 UTC) #4
Tom Sepez
LGTM, you may need to manually rebase to make CQ happy.
4 years, 8 months ago (2016-04-06 20:38:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864973005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864973005/40001
4 years, 8 months ago (2016-04-06 20:50:12 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 21:33:13 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/7222ea6936cbcff886037e4d8d4018e13a7f...

Powered by Google App Engine
This is Rietveld 408576698