Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1864963002: Rename unchecked functions to appropriate name. (Closed)

Created:
4 years, 8 months ago by Seigo Nonaka
Modified:
4 years, 8 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename unchecked functions to appropriate name. This CL renames - uncheckedNextOffset to nextGraphemeBoundaryOf - uncheckedPreviousOffset to previousGraphemeBoundaryOf - uncheckedPreviousOffsetForBackwardDeletion to previousBackwardDeletionOffsetOf Any behavior change is not expected with this CL. BUG=594923 Committed: https://crrev.com/d15ff702c781320745344f6545abe32be0fbb900 Cr-Commit-Position: refs/heads/master@{#385435}

Patch Set 1 #

Patch Set 2 : Fix typo /nextGraphmeBoundaryOf/nextGraphemeBoundaryOf/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -253 lines) Patch
M third_party/WebKit/Source/core/editing/EditingUtilities.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 1 5 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp View 1 6 chunks +240 lines, -240 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PositionIterator.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Seigo Nonaka
Hi Yoshi-san, could you kindly take a look? Thank you.
4 years, 8 months ago (2016-04-06 08:58:31 UTC) #2
yosin_UTC9
lgtm
4 years, 8 months ago (2016-04-06 09:10:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864963002/1
4 years, 8 months ago (2016-04-06 09:11:03 UTC) #5
Seigo Nonaka
Thank you for your quick review and pushing to CQ.
4 years, 8 months ago (2016-04-06 09:18:07 UTC) #6
Seigo Nonaka
I'm sorry I found one typo /Graphme/Grapheme/ Submitting with assuming still lgtm. Please let me ...
4 years, 8 months ago (2016-04-06 09:49:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864963002/20001
4 years, 8 months ago (2016-04-06 09:49:27 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-06 11:14:34 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 11:15:50 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d15ff702c781320745344f6545abe32be0fbb900
Cr-Commit-Position: refs/heads/master@{#385435}

Powered by Google App Engine
This is Rietveld 408576698