Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1864953003: [heap] Unify LargePage, NewSpacePage, and Page allocation (Closed)

Created:
4 years, 8 months ago by Michael Lippautz
Modified:
4 years, 8 months ago
Reviewers:
ulan
CC:
ulan, Hannes Payer (out of office), v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Unify LargePage, NewSpacePage, and Page allocation BUG= Committed: https://crrev.com/260df721d45c7611180b837bed8af8b3f0dad9c0 Cr-Commit-Position: refs/heads/master@{#35284}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -29 lines) Patch
M src/heap/spaces.h View 7 chunks +10 lines, -11 lines 0 comments Download
M src/heap/spaces.cc View 3 chunks +7 lines, -16 lines 0 comments Download
M src/heap/spaces-inl.h View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864953003/1
4 years, 8 months ago (2016-04-06 07:25:53 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-06 07:51:21 UTC) #4
Michael Lippautz
ptal
4 years, 8 months ago (2016-04-06 07:52:05 UTC) #6
ulan
lgtm
4 years, 8 months ago (2016-04-06 08:36:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864953003/1
4 years, 8 months ago (2016-04-06 08:39:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 08:41:32 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 08:43:19 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/260df721d45c7611180b837bed8af8b3f0dad9c0
Cr-Commit-Position: refs/heads/master@{#35284}

Powered by Google App Engine
This is Rietveld 408576698