ash/mash: Fix painting of status-tray bubble.

ash/mash: Fix painting of status-tray bubble.

Change NativeWidgetMus::GetLayer() to return the correct ui::Layer, to make sure
that the layer-tree for the Views in a Widget is added a child to the Layer
associated with the Widget.

BUG=598914
Committed: https://crrev.com/336b3700484b2fba745b756f22ea85db854e0c10
Cr-Commit-Position: refs/heads/master@{#385463}

[sadrul, 2016-04-06 02:08:22]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-04-06 02:59:03]

LGTM

[sky, 2016-04-06 02:59:18]

If you can, add a test for this. It's subtle.

[James Cook, 2016-04-06 03:44:16]

Awesome that you found a fix for this!

https://codereview.chromium.org/1864953002/diff/1/ui/views/mus/native_widget_...
File ui/views/mus/native_widget_mus.cc (right):

https://codereview.chromium.org/1864953002/diff/1/ui/views/mus/native_widget_...
ui/views/mus/native_widget_mus.cc:475: return
window_tree_host_->window()->layer()->GetCompositor();
Drive-by question... I presume this doesn't need to change to
content_->layer()->GetCompositor() also?  I'm not familiar with the compositor
system, but I see lots of ways to get compositors:

window_tree_host_->compositor()
window_tree_host_->window()->layer()->GetCompositor()
content_->layer()->GetCompositor()

Are they all the same?

[James Cook, 2016-04-06 03:45:23]

Description was changed from

==========
ash/mash: Fix painting of status-tray bubble.

Change NativeWidgetMus::GetLayer() to return the correct ui::Layer, to make sure
that the layer-tree for the Views in a Widget is added a child to the Layer
associated with the Widget.

BUG=598914
==========

to

==========
ash/mash: Fix painting of status-tray bubble.

Change NativeWidgetMus::GetLayer() to return the correct ui::Layer, to make sure
that the layer-tree for the Views in a Widget is added a child to the Layer
associated with the Widget.

BUG=598914
==========

[sadrul, 2016-04-06 14:05:44]

Added a test.

https://codereview.chromium.org/1864953002/diff/1/ui/views/mus/native_widget_...
File ui/views/mus/native_widget_mus.cc (right):

https://codereview.chromium.org/1864953002/diff/1/ui/views/mus/native_widget_...
ui/views/mus/native_widget_mus.cc:475: return
window_tree_host_->window()->layer()->GetCompositor();
On 2016/04/06 03:44:16, James Cook wrote:
> Drive-by question... I presume this doesn't need to change to
> content_->layer()->GetCompositor() also?  I'm not familiar with the compositor
> system, but I see lots of ways to get compositors:
> 
> window_tree_host_->compositor()
> window_tree_host_->window()->layer()->GetCompositor()
> content_->layer()->GetCompositor()
> 
> Are they all the same?

Yes, the entire layer-tree share the same compositor, which is owned by the
WindowTreeHost instance the hosts the layer-tree.

I have changed this code to just use window_tree_host_->compositor() here, it's
simpler than having to go through the window()->layer()

[sky, 2016-04-06 14:56:27]

SLGTM

[sadrul, 2016-04-06 14:57:37]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2016-04-06 14:57:38]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1864953002/#ps20001
(title: "test")

[commit-bot: I haz the power, 2016-04-06 14:57:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1864953002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1864953002/20001

[commit-bot: I haz the power, 2016-04-06 15:02:34]

Description was changed from

==========
ash/mash: Fix painting of status-tray bubble.

Change NativeWidgetMus::GetLayer() to return the correct ui::Layer, to make sure
that the layer-tree for the Views in a Widget is added a child to the Layer
associated with the Widget.

BUG=598914
==========

to

==========
ash/mash: Fix painting of status-tray bubble.

Change NativeWidgetMus::GetLayer() to return the correct ui::Layer, to make sure
that the layer-tree for the Views in a Widget is added a child to the Layer
associated with the Widget.

BUG=598914
==========

[commit-bot: I haz the power, 2016-04-06 15:02:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-06 15:03:26]

Description was changed from

==========
ash/mash: Fix painting of status-tray bubble.

Change NativeWidgetMus::GetLayer() to return the correct ui::Layer, to make sure
that the layer-tree for the Views in a Widget is added a child to the Layer
associated with the Widget.

BUG=598914
==========

to

==========
ash/mash: Fix painting of status-tray bubble.

Change NativeWidgetMus::GetLayer() to return the correct ui::Layer, to make sure
that the layer-tree for the Views in a Widget is added a child to the Layer
associated with the Widget.

BUG=598914

Committed: https://crrev.com/336b3700484b2fba745b756f22ea85db854e0c10
Cr-Commit-Position: refs/heads/master@{#385463}
==========

[commit-bot: I haz the power, 2016-04-06 15:03:27]

Patchset 2 (id:??) landed as
https://crrev.com/336b3700484b2fba745b756f22ea85db854e0c10
Cr-Commit-Position: refs/heads/master@{#385463}