Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1218)

Issue 1864923002: Revert of Large heap collection type hits assertion in Heap::allocationSizeFromSize (Closed)

Created:
4 years, 8 months ago by keishi
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Large heap collection type hits assertion in Heap::allocationSizeFromSize (patchset #2 id:20001 of https://codereview.chromium.org/1842263004/ ) Reason for revert: Caused crash on perf bots. crbug.com/600377 Original issue's description: > Large heap collection type hits assertion in Heap::allocationSizeFromSize > > allocationSizeFromSize is called for large object page allocations as well. > > BUG=597953 > > Committed: https://crrev.com/57a75864e012b06db30f4b027e24f5fd758e46a3 > Cr-Commit-Position: refs/heads/master@{#384230} TBR=oilpan-reviews@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=597953 Committed: https://crrev.com/c3d03859aa54039e399d2938c09f24fbcb1e8fd3 Cr-Commit-Position: refs/heads/master@{#385379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -21 lines) Patch
M third_party/WebKit/Source/platform/heap/Heap.h View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
keishi
Created Revert of Large heap collection type hits assertion in Heap::allocationSizeFromSize
4 years, 8 months ago (2016-04-06 01:33:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864923002/1
4 years, 8 months ago (2016-04-06 01:34:02 UTC) #2
haraken
LGTM to revert.
4 years, 8 months ago (2016-04-06 01:35:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864923002/1
4 years, 8 months ago (2016-04-06 01:36:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 03:44:02 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 03:45:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3d03859aa54039e399d2938c09f24fbcb1e8fd3
Cr-Commit-Position: refs/heads/master@{#385379}

Powered by Google App Engine
This is Rietveld 408576698