Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1864893003: Remove IFX_FontEnumerator (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove IFX_FontEnumerator Interface is never implemented. BUG=pdfium:468 Committed: https://pdfium.googlesource.com/pdfium/+/cdc1369969ebbc3a85670686490975be835efd19

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -23 lines) Patch
M core/fxge/ge/fx_ge_fontmap.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/fxge/include/fx_font.h View 1 4 chunks +3 lines, -16 lines 0 comments Download
M core/fxge/win32/fx_win32_device.cpp View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-04-06 20:24:10 UTC) #2
Lei Zhang
lgtm
4 years, 8 months ago (2016-04-06 20:27:52 UTC) #3
Tom Sepez
lgtm https://codereview.chromium.org/1864893003/diff/1/core/fxge/include/fx_font.h File core/fxge/include/fx_font.h (right): https://codereview.chromium.org/1864893003/diff/1/core/fxge/include/fx_font.h#newcode308 core/fxge/include/fx_font.h:308: std::vector<CFX_ByteString> m_InstalledTTFonts; nit: move this public member below ...
4 years, 8 months ago (2016-04-06 20:35:13 UTC) #4
dsinclair
https://codereview.chromium.org/1864893003/diff/1/core/fxge/include/fx_font.h File core/fxge/include/fx_font.h (right): https://codereview.chromium.org/1864893003/diff/1/core/fxge/include/fx_font.h#newcode308 core/fxge/include/fx_font.h:308: std::vector<CFX_ByteString> m_InstalledTTFonts; On 2016/04/06 20:35:13, Tom Sepez wrote: > ...
4 years, 8 months ago (2016-04-06 20:39:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864893003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864893003/20001
4 years, 8 months ago (2016-04-06 20:39:26 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 21:02:09 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/cdc1369969ebbc3a85670686490975be835e...

Powered by Google App Engine
This is Rietveld 408576698