Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 186483007: Removes specifying transient at the aura level for top levels (Closed)

Created:
6 years, 9 months ago by sky
Modified:
6 years, 9 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina, ben+views_chromium.org
Visibility:
Public.

Description

Removes specifying transient at the aura level for top levels This causes problems as it means the aura::Window may be deleted out from under the DesktopNativeWidgetAura, which causes all sorts of woe. This code is no longer needed since DesktopWindowTreeHostX11 now deals with owned windows. BUG=344265 TEST=none R=erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255377

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sky
6 years, 9 months ago (2014-03-05 23:21:08 UTC) #1
Elliot Glaysher
lgtm (Good luck!)
6 years, 9 months ago (2014-03-05 23:27:26 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 9 months ago (2014-03-06 00:01:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/186483007/1
6 years, 9 months ago (2014-03-06 00:26:28 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 02:27:14 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) ash_unittests, telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=275857
6 years, 9 months ago (2014-03-06 02:27:14 UTC) #6
sky
The CQ bit was checked by sky@chromium.org
6 years, 9 months ago (2014-03-06 15:50:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/186483007/1
6 years, 9 months ago (2014-03-06 15:50:57 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 17:08:02 UTC) #9
Message was sent while issue was closed.
Change committed as 255377

Powered by Google App Engine
This is Rietveld 408576698