Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 186483006: Pepper: More FileDownloader cleanup. (Closed)

Created:
6 years, 9 months ago by teravest
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Pepper: More FileDownloader cleanup. This is part of a series of changes that cleans up code style and unnecessary members inside FileDownloader. I've kept this small to make the changes easier to review. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255497

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebased #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : test fix #

Patch Set 8 : #

Patch Set 9 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -51 lines) Patch
M ppapi/native_client/src/trusted/plugin/file_downloader.h View 1 2 3 chunks +0 lines, -3 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/file_downloader.cc View 1 2 3 4 5 6 5 chunks +41 lines, -48 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
teravest
6 years, 9 months ago (2014-03-05 21:55:38 UTC) #1
dmichael (off chromium)
lgtm
6 years, 9 months ago (2014-03-06 21:04:15 UTC) #2
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 9 months ago (2014-03-06 21:05:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/186483006/140001
6 years, 9 months ago (2014-03-06 21:19:46 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 21:35:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-06 21:35:23 UTC) #6
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 9 months ago (2014-03-06 21:43:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/186483006/140001
6 years, 9 months ago (2014-03-06 22:08:28 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 02:25:51 UTC) #9
Message was sent while issue was closed.
Change committed as 255497

Powered by Google App Engine
This is Rietveld 408576698