Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 186483005: Don't modify the alternate winstation DACL (Closed)

Created:
6 years, 9 months ago by jschuh
Modified:
6 years, 9 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Visibility:
Public.

Description

Don't modify the alternate winstation DACL Turns out the DACL won't apply in most cases, and may run some risk of bad interactions with third-party software. It's also mostly redundant given the existing job and desktop restrictions. BUG=346586 R=cpu TBR=cpu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255338

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M sandbox/win/src/window.cc View 1 chunk +1 line, -13 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
jschuh
ptal
6 years, 9 months ago (2014-03-05 20:37:45 UTC) #1
jschuh
On 2014/03/05 20:37:45, Justin Schuh wrote: > ptal Also, the bot errors are spurious. I'm ...
6 years, 9 months ago (2014-03-05 22:18:34 UTC) #2
jschuh
Got an over the shoulder lgtm from cpu.
6 years, 9 months ago (2014-03-06 02:10:47 UTC) #3
jschuh
The CQ bit was checked by jschuh@chromium.org
6 years, 9 months ago (2014-03-06 02:10:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/186483005/1
6 years, 9 months ago (2014-03-06 02:16:08 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 02:32:25 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=276002
6 years, 9 months ago (2014-03-06 02:32:25 UTC) #7
jschuh
The CQ bit was checked by jschuh@chromium.org
6 years, 9 months ago (2014-03-06 03:13:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/186483005/1
6 years, 9 months ago (2014-03-06 03:24:56 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 03:35:34 UTC) #10
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=156255
6 years, 9 months ago (2014-03-06 03:35:35 UTC) #11
jschuh
The CQ bit was checked by jschuh@chromium.org
6 years, 9 months ago (2014-03-06 04:07:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/186483005/1
6 years, 9 months ago (2014-03-06 04:11:32 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 14:11:32 UTC) #14
Message was sent while issue was closed. 
Change committed as 255338

Powered by Google App Engine
This is Rietveld 408576698