chrome/browser/ui/app_list/start_page_service_factory.cc - Issue 186483004: Add a skeleton Start Page to the experimental app list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/start_page_service_factory.cc

Issue 186483004: Add a skeleton Start Page to the experimental app list. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ares_change_experimental_animation

Patch Set: rework Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/app_list/start_page_service.cc ('K') | « chrome/browser/ui/app_list/start_page_service.cc ('k') | chrome/browser/ui/webui/app_list/start_page_ui.cc » ('j') | ui/app_list/app_list_switches.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/start_page_service_factory.cc

diff --git a/chrome/browser/ui/app_list/start_page_service_factory.cc b/chrome/browser/ui/app_list/start_page_service_factory.cc

index 636814a6665686f37cc2ff081812a527e221476f..ec2e5ad29c4a13606720980d3184b010a31ae594 100644

--- a/chrome/browser/ui/app_list/start_page_service_factory.cc

+++ b/chrome/browser/ui/app_list/start_page_service_factory.cc

@@ -20,8 +20,8 @@ namespace app_list {

// static

StartPageService* StartPageServiceFactory::GetForProfile(Profile* profile) {

- if (!CommandLine::ForCurrentProcess()->HasSwitch(

- ::switches::kShowAppListStartPage) &&

+ if (!app_list::switches::IsExperimentalAppListEnabled() &&

+ !app_list::switches::IsStartPageWebUIEnabled() &&

!app_list::switches::IsVoiceSearchEnabled()) {

return NULL;

xiyuan 2014/03/14 17:00:54 nit: fix the wrong indent since you touched here.

calamity 2014/05/07 06:11:52 Done.

}