Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Issue 1864823002: Added an option (-i) to have dump_syms output header information only. (Closed)

Created:
4 years, 8 months ago by David Yen
Modified:
4 years, 8 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Added an option (-i) to have dump_syms output header information only. It is often helpful to check if a particular symbol file dumped by dump_syms actually matches a version of a binary file we have. The symbol output contains an ID which can be used to see if it matches the binary file. Unfortunately, this ID is internally calculated and not a standard hash of the binary file. Being able to output the header information only will allow users to determine whether their symbol file is up to date or not. R=jochen@chromium.org BUG=561447 Committed: https://chromium.googlesource.com/breakpad/breakpad/+/b0e5f262334e9a4d9e083d0daf430be2202f0152

Patch Set 1 #

Patch Set 2 : Revert src/common/module (it was unnecessary) #

Patch Set 3 : rebase #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -83 lines) Patch
M src/common/linux/dump_symbols.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/common/linux/dump_symbols.cc View 1 2 3 5 chunks +71 lines, -18 lines 0 comments Download
M src/common/mac/dump_syms.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/common/mac/dump_syms.cc View 1 3 chunks +72 lines, -54 lines 0 comments Download
M src/tools/linux/dump_syms/dump_syms.cc View 4 chunks +19 lines, -9 lines 0 comments Download
M src/tools/mac/dump_syms/dump_syms_tool.cc View 4 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
David Yen
4 years, 8 months ago (2016-04-05 22:59:07 UTC) #1
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-06 04:12:45 UTC) #2
David Yen
On 2016/04/06 04:12:45, jochen - slow wrote: > lgtm Thanks for the review! I am ...
4 years, 8 months ago (2016-04-06 17:10:34 UTC) #3
Ted Mielczarek
FYI, the identifier in the MODULE line is not generally a hash on Linux/Mac. On ...
4 years, 8 months ago (2016-04-06 20:55:27 UTC) #4
David Yen
On 2016/04/06 20:55:27, Ted Mielczarek wrote: > FYI, the identifier in the MODULE line is ...
4 years, 8 months ago (2016-04-06 21:14:54 UTC) #6
jochen (gone - plz use gerrit)
4 years, 8 months ago (2016-04-08 02:37:55 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
b0e5f262334e9a4d9e083d0daf430be2202f0152 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698