Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1816)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1864813003: Remove CFX_SegmentedArray. (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove CFX_SegmentedArray. Recent changes appear to have made this unused. Committed: https://pdfium.googlesource.com/pdfium/+/6334af71040b6148e9001aad4bd134a6c6c14a8d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -271 lines) Patch
M core/fxcrt/fx_basic_array.cpp View 1 chunk +0 lines, -206 lines 0 comments Download
M core/fxcrt/include/fx_basic.h View 1 chunk +0 lines, -65 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Tom Sepez
Dan, nothing but red.
4 years, 8 months ago (2016-04-06 21:37:34 UTC) #3
Tom Sepez
And add Lei since Dan's not here right now.
4 years, 8 months ago (2016-04-06 22:25:03 UTC) #5
Lei Zhang
lgtm woot!
4 years, 8 months ago (2016-04-06 22:41:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864813003/1
4 years, 8 months ago (2016-04-06 22:44:16 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 22:56:39 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/6334af71040b6148e9001aad4bd134a6c6c1...

Powered by Google App Engine
This is Rietveld 408576698