media/capture/content/screen_capture_device_core.cc - Issue 1864813002: Tab/Desktop Capture: Use requests instead of timer-based refreshing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/capture/content/screen_capture_device_core.cc

Issue 1864813002: Tab/Desktop Capture: Use requests instead of timer-based refreshing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@video_refresh_from_sinks

Patch Set: Addressed comments from PS2, and sampling decision logic change w.r.t. recent animation. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « media/capture/content/screen_capture_device_core.h ('k') | media/capture/content/smooth_event_sampler.h » ('j') | media/capture/content/thread_safe_capture_oracle.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/capture/content/screen_capture_device_core.cc

diff --git a/media/capture/content/screen_capture_device_core.cc b/media/capture/content/screen_capture_device_core.cc

index 2b3f3cfaecfe3e799e2ef4821a7a1f93b23e5f09..6e9f3355888d0f0a36cd1e3ce5202aae7d1f6490 100644

--- a/media/capture/content/screen_capture_device_core.cc

+++ b/media/capture/content/screen_capture_device_core.cc

@@ -65,6 +65,17 @@ void ScreenCaptureDeviceCore::AllocateAndStart(

TransitionStateTo(kCapturing);

}

+void ScreenCaptureDeviceCore::RequestRefreshFrame() {

+ DCHECK(thread_checker_.CalledOnValidThread());

+ if (state_ != kCapturing)

+ return;

+ if (oracle_proxy_->AttemptPassiveRefresh())

+ return;

+ capture_machine_->MaybeCaptureForRefresh();

void ScreenCaptureDeviceCore::StopAndDeAllocate() {

DCHECK(thread_checker_.CalledOnValidThread());