content/browser/renderer_host/media/video_capture_buffer_pool.cc - Issue 1864813002: Tab/Desktop Capture: Use requests instead of timer-based refreshing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/video_capture_buffer_pool.cc

Issue 1864813002: Tab/Desktop Capture: Use requests instead of timer-based refreshing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@video_refresh_from_sinks

Patch Set: Addressed comments from PS2, and sampling decision logic change w.r.t. recent animation. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/media/capture/web_contents_video_capture_device_unittest.cc ('k') | media/capture/content/screen_capture_device_core.h » ('j') | media/capture/content/thread_safe_capture_oracle.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/video_capture_buffer_pool.cc

diff --git a/content/browser/renderer_host/media/video_capture_buffer_pool.cc b/content/browser/renderer_host/media/video_capture_buffer_pool.cc

index 831c060eabc27eba65b5a8f02883c8a762cb8eb7..91c660a64c1b6a2f88c602e739df52a29989491d 100644

--- a/content/browser/renderer_host/media/video_capture_buffer_pool.cc

+++ b/content/browser/renderer_host/media/video_capture_buffer_pool.cc

@@ -374,7 +374,9 @@ int VideoCaptureBufferPool::ResurrectLastForProducer(

it->second->pixel_format() == format &&

it->second->storage_type() == storage) {

it->second->set_held_by_producer(true);

- return last_relinquished_buffer_id_;

+ const int resurrected_buffer_id = last_relinquished_buffer_id_;

+ last_relinquished_buffer_id_ = kInvalidId;

+ return resurrected_buffer_id;

}

return kInvalidId;