Issue 18648002: add JSONP option to output of skpdiff

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18648002: add JSONP option to output of skpdiff (Closed)

Created:
7 years, 5 months ago by Zach Reizner

Modified:
7 years, 5 months ago

Reviewers:
bsalomon, djsollen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -6 lines)			Patch
M	experimental/skpdiff/SkDiffContext.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	experimental/skpdiff/SkDiffContext.cpp	View	2 chunks	+15 lines, -3 lines	0 comments	Download
M	experimental/skpdiff/main.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

Zach Reizner

JSONP makes it easier to load the data on the website when using it on ...

7 years, 5 months ago (2013-07-03 15:39:35 UTC) #1

bsalomon

On 2013/07/03 15:39:35, Zach Reizner wrote: > JSONP makes it easier to load the data ...

7 years, 5 months ago (2013-07-03 18:09:53 UTC) #2

djsollen

what is the downside to using CORS instead? http://en.wikipedia.org/wiki/Cross-origin_resource_sharing

7 years, 5 months ago (2013-07-03 18:44:23 UTC) #3

Zach Reizner

On 2013/07/03 18:44:23, djsollen wrote: > what is the downside to using CORS instead? > ...

7 years, 5 months ago (2013-07-03 19:03:17 UTC) #4

Zach Reizner

7 years, 5 months ago (2013-07-08 15:04:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r9907 (presubmit successful).