pkg/analyzer/lib/src/summary/resynthesize.dart - Issue 1864753002: Use isValidConst flag to distinguish between const / final expressions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/summary/resynthesize.dart

Issue 1864753002: Use isValidConst flag to distinguish between const / final expressions. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Merge and tweaks. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analyzer/lib/src/summary/resynthesize.dart

diff --git a/pkg/analyzer/lib/src/summary/resynthesize.dart b/pkg/analyzer/lib/src/summary/resynthesize.dart

index 0d50bf8dd1ca368f895f1c98b0c1568c01f5230a..63a7f0f022f03d2243ba518475b84a939eb3906f 100644

--- a/pkg/analyzer/lib/src/summary/resynthesize.dart

+++ b/pkg/analyzer/lib/src/summary/resynthesize.dart

@@ -286,7 +286,7 @@ class _ConstExprBuilder {

Expression get expr => stack.single;

Expression build() {

- if (uc.isInvalid) {

+ if (!uc.isValidConst) {

return AstFactory.identifier3(r'$$invalidConstExpr$$');

}

for (UnlinkedConstOperation operation in uc.operations) {

« no previous file with comments | « pkg/analyzer/lib/src/summary/link.dart ('k') | pkg/analyzer/lib/src/summary/summarize_const_expr.dart » ('j') | no next file with comments »