Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: pkg/analyzer/lib/src/summary/link.dart

Issue 1864753002: Use isValidConst flag to distinguish between const / final expressions. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Merge and tweaks. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/idl.dart ('k') | pkg/analyzer/lib/src/summary/resynthesize.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/summary/link.dart
diff --git a/pkg/analyzer/lib/src/summary/link.dart b/pkg/analyzer/lib/src/summary/link.dart
index ae63ef8f7a22e93d0adedf785edfb6dc45800d97..0f642efa3e31af68c2bcfd0fd7ac5a37cc1f67d7 100644
--- a/pkg/analyzer/lib/src/summary/link.dart
+++ b/pkg/analyzer/lib/src/summary/link.dart
@@ -2290,8 +2290,8 @@ class TypeInferenceNode extends Node<TypeInferenceNode> {
void evaluate(bool inCycle) {
if (inCycle) {
_inferredType = DynamicTypeImpl.instance;
- } else if (variableElement.unlinkedVariable.constExpr.isInvalid) {
- // TODO(paulberry): implement.
+ } else if (!variableElement.unlinkedVariable.constExpr.isValidConst) {
+ // TODO(paulberry): delete this case and fix errors.
throw new UnimplementedError();
} else {
// Perform RPN evaluation of the cycle, using a stack of
« no previous file with comments | « pkg/analyzer/lib/src/summary/idl.dart ('k') | pkg/analyzer/lib/src/summary/resynthesize.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698