Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1864753002: Use isValidConst flag to distinguish between const / final expressions. (Closed)

Created:
4 years, 8 months ago by scheglov
Modified:
4 years, 8 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use isValidConst flag to distinguish between const / final expressions. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/43efb6747154f926bbf9bc31ed879536b85d8a44

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merge and tweaks. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -69 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 8 chunks +14 lines, -14 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View 1 Binary file 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_const_expr.dart View 1 9 chunks +18 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 7 chunks +27 lines, -14 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 31 chunks +31 lines, -31 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 8 months ago (2016-04-05 21:13:14 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/1864753002/diff/1/pkg/analyzer/lib/src/summary/link.dart File pkg/analyzer/lib/src/summary/link.dart (right): https://codereview.chromium.org/1864753002/diff/1/pkg/analyzer/lib/src/summary/link.dart#newcode2294 pkg/analyzer/lib/src/summary/link.dart:2294: // TODO(paulberry): implement. So that I don't become ...
4 years, 8 months ago (2016-04-05 21:19:33 UTC) #2
scheglov
https://codereview.chromium.org/1864753002/diff/1/pkg/analyzer/lib/src/summary/link.dart File pkg/analyzer/lib/src/summary/link.dart (right): https://codereview.chromium.org/1864753002/diff/1/pkg/analyzer/lib/src/summary/link.dart#newcode2294 pkg/analyzer/lib/src/summary/link.dart:2294: // TODO(paulberry): implement. On 2016/04/05 21:19:33, Paul Berry wrote: ...
4 years, 8 months ago (2016-04-05 21:26:26 UTC) #3
scheglov
4 years, 8 months ago (2016-04-05 21:26:49 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
43efb6747154f926bbf9bc31ed879536b85d8a44 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698