Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1219)

Issue 1864743002: Use codec enum values instead of strings to initialize |media_format_map_|. (Closed)

Created:
4 years, 8 months ago by ddorwin
Modified:
4 years, 8 months ago
Reviewers:
hubbe, DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@enums
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use codec enum values instead of strings to initialize |media_format_map_|. BUG=461009 Committed: https://crrev.com/76675fed24686f366c32fac4f171affc6a36d1be Cr-Commit-Position: refs/heads/master@{#385351}

Patch Set 1 : use variables for webm types #

Patch Set 2 : actual change #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -45 lines) Patch
M media/base/mime_util_internal.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/base/mime_util_internal.cc View 1 2 3 chunks +51 lines, -44 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
ddorwin
No more confusing strings! While not the purpose of this CL, InitializeMimeTypeMaps() now runs in ...
4 years, 8 months ago (2016-04-05 21:18:30 UTC) #3
DaleCurtis
lgtm
4 years, 8 months ago (2016-04-05 21:20:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864743002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864743002/60001
4 years, 8 months ago (2016-04-05 22:38:58 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 8 months ago (2016-04-06 00:39:21 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 00:42:02 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/76675fed24686f366c32fac4f171affc6a36d1be
Cr-Commit-Position: refs/heads/master@{#385351}

Powered by Google App Engine
This is Rietveld 408576698