Prepare Chrome Extensions for ES2015 RegExp semantics

Prepare Chrome Extensions for ES2015 RegExp semantics

This patch maintains Chrome Extensions infrastructure resilient against
monkey-patching changes to RegExp.prototype by using exec directly.
ES2015 makes methods like RegExp.prototype.test and String.prototype.replace
call the current, rather than original, value of RegExp.prototype.exec.
This patch avoids calling those functions.

BUG=v8:4883
R=rdevlin.cronin@chromium.org,meacer@chromium.org
TEST=ran previously failing browser_tests with a version of V8 which includes
full ES2015 RegExp semantics, and observed it to pass.

Committed: https://crrev.com/a4d29aaa90d74d4461941f2255b93c9813817696
Cr-Commit-Position: refs/heads/master@{#385311}

[Dan Ehrenberg, 2016-04-05 20:20:43]

This new version addresses review feedback from
https://codereview.chromium.org/1863573004

[Devlin, 2016-04-05 20:37:51]

lgtm with nit

https://codereview.chromium.org/1864733002/diff/1/extensions/renderer/resourc...
File extensions/renderer/resources/binding.js (right):

https://codereview.chromium.org/1864733002/diff/1/extensions/renderer/resourc...
extensions/renderer/resources/binding.js:141: // Use exec rather than test to
defend against clobbering in the
Move this comment to safe_builtins.cc.

[Dan Ehrenberg, 2016-04-05 20:48:47]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2016-04-05 20:48:47]

https://codereview.chromium.org/1864733002/diff/1/extensions/renderer/resourc...
File extensions/renderer/resources/binding.js (right):

https://codereview.chromium.org/1864733002/diff/1/extensions/renderer/resourc...
extensions/renderer/resources/binding.js:141: // Use exec rather than test to
defend against clobbering in the
On 2016/04/05 at 20:37:50, Devlin wrote:
> Move this comment to safe_builtins.cc.

Done

[Dan Ehrenberg, 2016-04-05 20:48:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/1864733002/#ps20001
(title: "Move comment")

[commit-bot: I haz the power, 2016-04-05 20:49:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1864733002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1864733002/20001

[meacer, 2016-04-05 21:02:34]

Looks straightforward from a security perspective, lgtm too

[commit-bot: I haz the power, 2016-04-05 22:44:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-05 22:46:26]

Description was changed from

==========
Prepare Chrome Extensions for ES2015 RegExp semantics

This patch maintains Chrome Extensions infrastructure resilient against
monkey-patching changes to RegExp.prototype by using exec directly.
ES2015 makes methods like RegExp.prototype.test and String.prototype.replace
call the current, rather than original, value of RegExp.prototype.exec.
This patch avoids calling those functions.

BUG=v8:4883
R=rdevlin.cronin@chromium.org,meacer@chromium.org
TEST=ran previously failing browser_tests with a version of V8 which includes
full ES2015 RegExp semantics, and observed it to pass.
==========

to

==========
Prepare Chrome Extensions for ES2015 RegExp semantics

This patch maintains Chrome Extensions infrastructure resilient against
monkey-patching changes to RegExp.prototype by using exec directly.
ES2015 makes methods like RegExp.prototype.test and String.prototype.replace
call the current, rather than original, value of RegExp.prototype.exec.
This patch avoids calling those functions.

BUG=v8:4883
R=rdevlin.cronin@chromium.org,meacer@chromium.org
TEST=ran previously failing browser_tests with a version of V8 which includes
full ES2015 RegExp semantics, and observed it to pass.

Committed: https://crrev.com/a4d29aaa90d74d4461941f2255b93c9813817696
Cr-Commit-Position: refs/heads/master@{#385311}
==========

[commit-bot: I haz the power, 2016-04-05 22:46:27]

Patchset 2 (id:??) landed as
https://crrev.com/a4d29aaa90d74d4461941f2255b93c9813817696
Cr-Commit-Position: refs/heads/master@{#385311}