Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: runtime/bin/extensions.h

Issue 186473003: Refactor native extension shared library lookup. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add check for loading from http(s): Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/extensions.h
diff --git a/runtime/bin/extensions.h b/runtime/bin/extensions.h
index 6f3853c5d379d2cb2b8606759317e410cfbaffd8..2b4e19bffd3de6e2f43f4e9d8a59e09d31138e2d 100644
--- a/runtime/bin/extensions.h
+++ b/runtime/bin/extensions.h
@@ -16,7 +16,9 @@ class Extensions {
public:
// TODO(whesse): Make extension load from a relative path relative to
// the library it is in. Currently loads from current working directory.
- static Dart_Handle LoadExtension(const char* extension_url,
+ static Dart_Handle LoadExtension(const char* extension_directory,
+ const char* extension_filename,
+ const char* extension_name,
Dart_Handle parent_library);
private:
@@ -24,8 +26,7 @@ class Extensions {
static char* Concatenate(const char** strings);
// Platform-specific implementations.
- static void* LoadExtensionLibrary(const char* library_path,
- const char* extension_name);
+ static void* LoadExtensionLibrary(const char* library_file);
static void* ResolveSymbol(void* lib_handle, const char* symbol);
DISALLOW_ALLOCATION();

Powered by Google App Engine
This is Rietveld 408576698