gpu/blink/webgraphicscontext3d_impl.h - Issue 1864723003: Make lost context and error message callbacks on GpuControl go to client

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/blink/webgraphicscontext3d_impl.h

Issue 1864723003: Make lost context and error message callbacks on GpuControl go to client (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: errorcallback: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/pepper/ppb_graphics_3d_impl.cc ('k') | gpu/blink/webgraphicscontext3d_impl.cc » ('j') | gpu/blink/webgraphicscontext3d_in_process_command_buffer_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/blink/webgraphicscontext3d_impl.h

diff --git a/gpu/blink/webgraphicscontext3d_impl.h b/gpu/blink/webgraphicscontext3d_impl.h

index 0dc5bc58bf3715c346dfbbdacc5aaff977e3537a..db2b82c1fd4ef00c739435a64fc3e6390229763c 100644

--- a/gpu/blink/webgraphicscontext3d_impl.h

+++ b/gpu/blink/webgraphicscontext3d_impl.h

@@ -52,21 +52,15 @@ class GPU_BLINK_EXPORT WebGraphicsContext3DImpl

WebGraphicsContext3DImpl();

- ::gpu::gles2::GLES2ImplementationErrorMessageCallback*

- getErrorMessageCallback();

- virtual void OnErrorMessage(const std::string& message, int id);

+ void OnErrorMessage(const char* message, int32_t id);

void SetGLInterface(::gpu::gles2::GLES2Interface* gl) { gl_ = gl; }

bool initialized_;

bool initialize_failed_;

- WebGraphicsContext3D::WebGraphicsContextLostCallback* context_lost_callback_;

- WebGraphicsContext3D::WebGraphicsErrorMessageCallback*

- error_message_callback_;

- scoped_ptr<WebGraphicsContext3DErrorMessageCallback>

- client_error_message_callback_;

+ WebGraphicsContextLostCallback* context_lost_callback_;

+ WebGraphicsErrorMessageCallback* error_message_callback_;

::gpu::gles2::GLES2Interface* gl_;

bool lose_context_when_out_of_memory_;