Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1864713002: Set keyboard layout in MUS. (Closed)

Created:
4 years, 8 months ago by kylechar
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set keyboard layout in MUS. The keyboard layout needs to be set when running mash on device otherwise key input events are broken. It looks like this is normally done as part of login, so set a US keyboard layout until we've got login working. BUG=600809 Committed: https://crrev.com/7ca8ef21096afe3b39c16557084b86e42ebd15cc Cr-Commit-Position: refs/heads/master@{#385307}

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M components/mus/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/mus_app.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
kylechar
4 years, 8 months ago (2016-04-05 19:33:47 UTC) #4
kylechar
4 years, 8 months ago (2016-04-05 19:33:47 UTC) #5
sky
LGTM https://codereview.chromium.org/1864713002/diff/1/components/mus/mus_app.cc File components/mus/mus_app.cc (right): https://codereview.chromium.org/1864713002/diff/1/components/mus/mus_app.cc#newcode32 components/mus/mus_app.cc:32: #include "ui/events/ozone/layout/keyboard_layout_engine.h" Move to 42ish?
4 years, 8 months ago (2016-04-05 20:27:45 UTC) #7
kylechar
Thanks sky! https://codereview.chromium.org/1864713002/diff/1/components/mus/mus_app.cc File components/mus/mus_app.cc (right): https://codereview.chromium.org/1864713002/diff/1/components/mus/mus_app.cc#newcode32 components/mus/mus_app.cc:32: #include "ui/events/ozone/layout/keyboard_layout_engine.h" On 2016/04/05 at 20:27:45, sky ...
4 years, 8 months ago (2016-04-05 21:44:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864713002/20001
4 years, 8 months ago (2016-04-05 21:44:49 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 22:40:02 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 22:41:08 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7ca8ef21096afe3b39c16557084b86e42ebd15cc
Cr-Commit-Position: refs/heads/master@{#385307}

Powered by Google App Engine
This is Rietveld 408576698