Issue 1864683002: Don't run build_deb.py on Windows GN

Issue 1864683002: Don't run build_deb.py on Windows GN (Closed)

Created:
4 years, 8 months ago by scottmg

Modified:
4 years, 8 months ago

Reviewers:
Sergey Ulanov, Dirk Pranke

CC:
chromium-reviews, chromoting-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Don't run build_deb.py on Windows GN Otherwise: gn gen //out/Debug "--args=is_debug=true is_component_build=true enable_nacl=false is_chrome_branded=true symbol_level=2 target_cpu=\"x86\"" --check Traceback (most recent call last): File "d:/src/cr3/src/remoting/host/installer/linux/build_deb.py", line 22, in <module> sys.exit(main()) File "d:/src/cr3/src/remoting/host/installer/linux/build_deb.py", line 15, in main stdout=subprocess.PIPE) File "d:\src\depot_tools\python276_bin\lib\subprocess.py", line 709, in __init__ errread, errwrite) File "d:\src\depot_tools\python276_bin\lib\subprocess.py", line 957, in _execute_child startupinfo) WindowsError: [Error 193] %1 is not a valid Win32 application ERROR at //remoting/host/BUILD.gn:878:32: Script returned non-zero exit code. "$root_build_dir/" + exec_script(build_deb_script, ^---------- Current dir: d:/src/cr3/src/out/Debug/ Command: d:/src/depot_tools/python276_bin/python.exe -- d:/src/cr3/src/remoting/host/installer/linux/build_deb.py -p -s d:/src/cr3/src/ Returned 1. BUG=600789 Committed: https://crrev.com/e4203f09fa64c1c187a5e64c4650c1b27f995be8 Cr-Commit-Position: refs/heads/master@{#385265}

Patch Set 1 #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	remoting/host/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 14 (7 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scottmg

Description was changed from ========== Don't run build_deb.py on Windows GN Otherwise: gn gen //out/Debug ...

4 years, 8 months ago (2016-04-05 19:15:20 UTC) #4

Description was changed from

==========
Don't run build_deb.py on Windows GN

Otherwise:

gn gen //out/Debug "--args=is_debug=true is_component_build=true
enable_nacl=false is_chrome_branded=true symbol_level=2 target_cpu=\"x86\""
--check
Traceback (most recent call last):
  File "d:/src/cr3/src/remoting/host/installer/linux/build_deb.py", line 22, in
<module>
    sys.exit(main())
  File "d:/src/cr3/src/remoting/host/installer/linux/build_deb.py", line 15, in
main
    stdout=subprocess.PIPE)
  File "d:\src\depot_tools\python276_bin\lib\subprocess.py", line 709, in
__init__
    errread, errwrite)
  File "d:\src\depot_tools\python276_bin\lib\subprocess.py", line 957, in
_execute_child
    startupinfo)
WindowsError: [Error 193] %1 is not a valid Win32 application
ERROR at //remoting/host/BUILD.gn:878:32: Script returned non-zero exit code.
          "$root_build_dir/" + exec_script(build_deb_script,
                               ^----------
Current dir: d:/src/cr3/src/out/Debug/
Command: d:/src/depot_tools/python276_bin/python.exe --
d:/src/cr3/src/remoting/host/installer/linux/build_deb.py -p -s d:/src/cr3/src/
Returned 1.
==========

to

==========
Don't run build_deb.py on Windows GN

Otherwise:

gn gen //out/Debug "--args=is_debug=true is_component_build=true
enable_nacl=false is_chrome_branded=true symbol_level=2 target_cpu=\"x86\""
--check
Traceback (most recent call last):
  File "d:/src/cr3/src/remoting/host/installer/linux/build_deb.py", line 22, in
<module>
    sys.exit(main())
  File "d:/src/cr3/src/remoting/host/installer/linux/build_deb.py", line 15, in
main
    stdout=subprocess.PIPE)
  File "d:\src\depot_tools\python276_bin\lib\subprocess.py", line 709, in
__init__
    errread, errwrite)
  File "d:\src\depot_tools\python276_bin\lib\subprocess.py", line 957, in
_execute_child
    startupinfo)
WindowsError: [Error 193] %1 is not a valid Win32 application
ERROR at //remoting/host/BUILD.gn:878:32: Script returned non-zero exit code.
          "$root_build_dir/" + exec_script(build_deb_script,
                               ^----------
Current dir: d:/src/cr3/src/out/Debug/
Command: d:/src/depot_tools/python276_bin/python.exe --
d:/src/cr3/src/remoting/host/installer/linux/build_deb.py -p -s d:/src/cr3/src/
Returned 1.

BUG=600789
==========

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864683002/1

4 years, 8 months ago (2016-04-05 19:49:47 UTC) #9

commit-bot: I haz the power

Description was changed from ========== Don't run build_deb.py on Windows GN Otherwise: gn gen //out/Debug ...

4 years, 8 months ago (2016-04-05 19:55:10 UTC) #10

Message was sent while issue was closed.

Description was changed from

==========
Don't run build_deb.py on Windows GN

Otherwise:

gn gen //out/Debug "--args=is_debug=true is_component_build=true
enable_nacl=false is_chrome_branded=true symbol_level=2 target_cpu=\"x86\""
--check
Traceback (most recent call last):
  File "d:/src/cr3/src/remoting/host/installer/linux/build_deb.py", line 22, in
<module>
    sys.exit(main())
  File "d:/src/cr3/src/remoting/host/installer/linux/build_deb.py", line 15, in
main
    stdout=subprocess.PIPE)
  File "d:\src\depot_tools\python276_bin\lib\subprocess.py", line 709, in
__init__
    errread, errwrite)
  File "d:\src\depot_tools\python276_bin\lib\subprocess.py", line 957, in
_execute_child
    startupinfo)
WindowsError: [Error 193] %1 is not a valid Win32 application
ERROR at //remoting/host/BUILD.gn:878:32: Script returned non-zero exit code.
          "$root_build_dir/" + exec_script(build_deb_script,
                               ^----------
Current dir: d:/src/cr3/src/out/Debug/
Command: d:/src/depot_tools/python276_bin/python.exe --
d:/src/cr3/src/remoting/host/installer/linux/build_deb.py -p -s d:/src/cr3/src/
Returned 1.

BUG=600789
==========

to

==========
Don't run build_deb.py on Windows GN

Otherwise:

gn gen //out/Debug "--args=is_debug=true is_component_build=true
enable_nacl=false is_chrome_branded=true symbol_level=2 target_cpu=\"x86\""
--check
Traceback (most recent call last):
  File "d:/src/cr3/src/remoting/host/installer/linux/build_deb.py", line 22, in
<module>
    sys.exit(main())
  File "d:/src/cr3/src/remoting/host/installer/linux/build_deb.py", line 15, in
main
    stdout=subprocess.PIPE)
  File "d:\src\depot_tools\python276_bin\lib\subprocess.py", line 709, in
__init__
    errread, errwrite)
  File "d:\src\depot_tools\python276_bin\lib\subprocess.py", line 957, in
_execute_child
    startupinfo)
WindowsError: [Error 193] %1 is not a valid Win32 application
ERROR at //remoting/host/BUILD.gn:878:32: Script returned non-zero exit code.
          "$root_build_dir/" + exec_script(build_deb_script,
                               ^----------
Current dir: d:/src/cr3/src/out/Debug/
Command: d:/src/depot_tools/python276_bin/python.exe --
d:/src/cr3/src/remoting/host/installer/linux/build_deb.py -p -s d:/src/cr3/src/
Returned 1.

BUG=600789
==========

commit-bot: I haz the power

Description was changed from ========== Don't run build_deb.py on Windows GN Otherwise: gn gen //out/Debug ...

4 years, 8 months ago (2016-04-05 19:57:37 UTC) #12

Message was sent while issue was closed.

Description was changed from

==========
Don't run build_deb.py on Windows GN

Otherwise:

gn gen //out/Debug "--args=is_debug=true is_component_build=true
enable_nacl=false is_chrome_branded=true symbol_level=2 target_cpu=\"x86\""
--check
Traceback (most recent call last):
  File "d:/src/cr3/src/remoting/host/installer/linux/build_deb.py", line 22, in
<module>
    sys.exit(main())
  File "d:/src/cr3/src/remoting/host/installer/linux/build_deb.py", line 15, in
main
    stdout=subprocess.PIPE)
  File "d:\src\depot_tools\python276_bin\lib\subprocess.py", line 709, in
__init__
    errread, errwrite)
  File "d:\src\depot_tools\python276_bin\lib\subprocess.py", line 957, in
_execute_child
    startupinfo)
WindowsError: [Error 193] %1 is not a valid Win32 application
ERROR at //remoting/host/BUILD.gn:878:32: Script returned non-zero exit code.
          "$root_build_dir/" + exec_script(build_deb_script,
                               ^----------
Current dir: d:/src/cr3/src/out/Debug/
Command: d:/src/depot_tools/python276_bin/python.exe --
d:/src/cr3/src/remoting/host/installer/linux/build_deb.py -p -s d:/src/cr3/src/
Returned 1.

BUG=600789
==========

to

==========
Don't run build_deb.py on Windows GN

Otherwise:

gn gen //out/Debug "--args=is_debug=true is_component_build=true
enable_nacl=false is_chrome_branded=true symbol_level=2 target_cpu=\"x86\""
--check
Traceback (most recent call last):
  File "d:/src/cr3/src/remoting/host/installer/linux/build_deb.py", line 22, in
<module>
    sys.exit(main())
  File "d:/src/cr3/src/remoting/host/installer/linux/build_deb.py", line 15, in
main
    stdout=subprocess.PIPE)
  File "d:\src\depot_tools\python276_bin\lib\subprocess.py", line 709, in
__init__
    errread, errwrite)
  File "d:\src\depot_tools\python276_bin\lib\subprocess.py", line 957, in
_execute_child
    startupinfo)
WindowsError: [Error 193] %1 is not a valid Win32 application
ERROR at //remoting/host/BUILD.gn:878:32: Script returned non-zero exit code.
          "$root_build_dir/" + exec_script(build_deb_script,
                               ^----------
Current dir: d:/src/cr3/src/out/Debug/
Command: d:/src/depot_tools/python276_bin/python.exe --
d:/src/cr3/src/remoting/host/installer/linux/build_deb.py -p -s d:/src/cr3/src/
Returned 1.

BUG=600789

Committed: https://crrev.com/e4203f09fa64c1c187a5e64c4650c1b27f995be8
Cr-Commit-Position: refs/heads/master@{#385265}
==========

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/e4203f09fa64c1c187a5e64c4650c1b27f995be8 Cr-Commit-Position: refs/heads/master@{#385265}

4 years, 8 months ago (2016-04-05 19:57:39 UTC) #13

brucedawson

4 years, 8 months ago (2016-04-06 01:02:22 UTC) #14

Message was sent while issue was closed.

On 2016/04/05 19:57:39, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/e4203f09fa64c1c187a5e64c4650c1b27f995be8
> Cr-Commit-Position: refs/heads/master@{#385265}

Thanks. I hit that also but hadn't landed my fix yet.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages