Web Animations: define distance for AnimatableColor

Web Animations: define distance for AnimatableColor

Distance is defined in
http://dev.w3.org/fxtf/web-animations/ section 4.1.3.5

Web Animations use property distance calculations in paced keyframe animation effects, in assigning the timing for keyframes so that a 'paced' property changes at constant velocity.

BUG=348896
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168559

[alancutter (OOO until 2018), 2014-03-04 07:25:54]

https://codereview.chromium.org/186463002/diff/1/Source/core/animation/Animat...
File Source/core/animation/AnimatableColor.cpp (right):

https://codereview.chromium.org/186463002/diff/1/Source/core/animation/Animat...
Source/core/animation/AnimatableColor.cpp:131: return
m_color.distanceTo(color->m_color);
timloh: Should m_visitedLinkColor be included here?

[Timothy Loh, 2014-03-05 00:40:35]

https://codereview.chromium.org/186463002/diff/1/Source/core/animation/Animat...
File Source/core/animation/AnimatableColor.cpp (right):

https://codereview.chromium.org/186463002/diff/1/Source/core/animation/Animat...
Source/core/animation/AnimatableColor.cpp:131: return
m_color.distanceTo(color->m_color);
On 2014/03/04 07:25:54, alancutter wrote:
> timloh: Should m_visitedLinkColor be included here?

Probably not. Leaving it like this is probably best even though we'll have paced
colors be slightly wonky if you have visited colors differing to unvisited
colors.

[shans, 2014-03-05 00:44:18]

lgtm

[Eric Willigers, 2014-03-05 01:05:01]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2014-03-05 01:08:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/186463002/4...

[commit-bot: I haz the power, 2014-03-05 01:29:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-05 01:30:00]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[Eric Willigers, 2014-03-05 02:20:07]

+dstockwell

[alancutter (OOO until 2018), 2014-03-05 03:12:51]

The description should have a link to the spec and maybe a brief description to
state that this is part of implementing paced keyframe spacing.

[dstockwell, 2014-03-05 03:16:56]

https://codereview.chromium.org/186463002/diff/40001/Source/core/animation/An...
File Source/core/animation/AnimatableColor.cpp (right):

https://codereview.chromium.org/186463002/diff/40001/Source/core/animation/An...
Source/core/animation/AnimatableColor.cpp:97: return sqrt(square(m_red -
other.m_red)
This appears to match the computation defined in the FPWD. We should be tracking
the latest draft.

https://codereview.chromium.org/186463002/diff/40001/Source/core/animation/An...
File Source/core/animation/AnimatableValue.cpp (right):

https://codereview.chromium.org/186463002/diff/40001/Source/core/animation/An...
Source/core/animation/AnimatableValue.cpp:80: 
extra line added

[Eric Willigers, 2014-03-05 03:53:04]

On 2014/03/05 03:12:51, alancutter wrote:
> The description should have a link to the spec and maybe a brief description
to
> state that this is part of implementing paced keyframe spacing.

Done

[Eric Willigers, 2014-03-05 03:54:48]

https://codereview.chromium.org/186463002/diff/40001/Source/core/animation/An...
File Source/core/animation/AnimatableColor.cpp (right):

https://codereview.chromium.org/186463002/diff/40001/Source/core/animation/An...
Source/core/animation/AnimatableColor.cpp:97: return sqrt(square(m_red -
other.m_red)
On 2014/03/05 03:16:57, dstockwell wrote:
> This appears to match the computation defined in the FPWD. We should be
tracking
> the latest draft.

I used  http://dev.w3.org/fxtf/web-animations/

The MathML sqrt is visible when we view source, or use Firefox.

sqrt((R<sub>end</sub> - R<sub>start</sub>)^2 +
     (G<sub>end</sub> - G<sub>start</sub>)^2 +
     (B<sub>end</sub> - B<sub>start</sub>)^2 +
     (A<sub>end</sub> - A<sub>start</sub>)^2)

https://codereview.chromium.org/186463002/diff/40001/Source/core/animation/An...
File Source/core/animation/AnimatableValue.cpp (right):

https://codereview.chromium.org/186463002/diff/40001/Source/core/animation/An...
Source/core/animation/AnimatableValue.cpp:80: 
On 2014/03/05 03:16:57, dstockwell wrote:
> extra line added

Done.

[dstockwell, 2014-03-05 04:02:48]

lgtm

On 2014/03/05 03:54:48, Eric Willigers wrote:
>
https://codereview.chromium.org/186463002/diff/40001/Source/core/animation/An...
> File Source/core/animation/AnimatableColor.cpp (right):
> 
>
https://codereview.chromium.org/186463002/diff/40001/Source/core/animation/An...
> Source/core/animation/AnimatableColor.cpp:97: return sqrt(square(m_red -
> other.m_red)
> On 2014/03/05 03:16:57, dstockwell wrote:
> > This appears to match the computation defined in the FPWD. We should be
> tracking
> > the latest draft.
> 
> I used  http://dev.w3.org/fxtf/web-animations/
> 
> The MathML sqrt is visible when we view source, or use Firefox.

Ahh, that's amusing, I wonder if there's a MathML polyfill we should be using in
the draft.

> sqrt((R<sub>end</sub> - R<sub>start</sub>)^2 +
>      (G<sub>end</sub> - G<sub>start</sub>)^2 +
>      (B<sub>end</sub> - B<sub>start</sub>)^2 +
>      (A<sub>end</sub> - A<sub>start</sub>)^2)
> 
>
https://codereview.chromium.org/186463002/diff/40001/Source/core/animation/An...
> File Source/core/animation/AnimatableValue.cpp (right):
> 
>
https://codereview.chromium.org/186463002/diff/40001/Source/core/animation/An...
> Source/core/animation/AnimatableValue.cpp:80: 
> On 2014/03/05 03:16:57, dstockwell wrote:
> > extra line added
> 
> Done.

[Eric Willigers, 2014-03-05 04:03:55]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2014-03-05 04:04:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/186463002/6...

[Eric Willigers, 2014-03-05 06:04:01]

The CQ bit was unchecked by ericwilligers@chromium.org

[Eric Willigers, 2014-03-05 06:04:01]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2014-03-05 20:55:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/186463002/6...

[commit-bot: I haz the power, 2014-03-06 03:47:00]

Change committed as 168559