Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 1864603002: Rename stdio.h wrapper file to stdio_wrapper.h. (Closed)

Created:
4 years, 8 months ago by yxma
Modified:
4 years, 8 months ago
Reviewers:
Mark Mentovai, labath
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename stdio.h wrapper file to stdio_wrapper.h. Some projects will get build break because the comipler is confused when searches for the standard stdio.h. Rename the wrapper file to avoid that. renamed: src/common/stdio.h -> src/common/stdio_wrapper.h modified: src/processor/minidump.cc modified: src/processor/dump_context.cc modified: src/processor/logging.cc modified: src/processor/minidump.cc modified: src/processor/minidump_processor.cc modified: src/processor/stackwalk_common.cc modified: src/processor/symbolic_constants_win.cc R=mark@chromium.org, labath@google.com Committed: https://chromium.googlesource.com/breakpad/breakpad/+/46359276c8c72c56e4103c90be22bbfda32c942d

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix the macro name after file renaming. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -52 lines) Patch
D src/common/stdio.h View 1 chunk +0 lines, -43 lines 0 comments Download
A + src/common/stdio_wrapper.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/processor/dump_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/logging.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/minidump.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/minidump_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/stackwalk_common.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/symbolic_constants_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
yxma
4 years, 8 months ago (2016-04-05 17:59:21 UTC) #1
Mark Mentovai
It’s pretty sad that a build system can’t deal with this. Oh well. https://codereview.chromium.org/1864603002/diff/1/src/common/stdio_wrapper.h File ...
4 years, 8 months ago (2016-04-05 18:19:02 UTC) #2
yxma
4 years, 8 months ago (2016-04-05 18:35:20 UTC) #3
yxma
On 2016/04/05 18:19:02, Mark Mentovai wrote: > It’s pretty sad that a build system can’t ...
4 years, 8 months ago (2016-04-05 18:36:45 UTC) #4
Mark Mentovai
LGTM
4 years, 8 months ago (2016-04-05 19:45:17 UTC) #8
Mark Mentovai
Committed patchset #2 (id:20001) manually as 46359276c8c72c56e4103c90be22bbfda32c942d (presubmit successful).
4 years, 8 months ago (2016-04-05 19:45:34 UTC) #10
yxma
4 years, 8 months ago (2016-04-05 20:22:54 UTC) #11
Message was sent while issue was closed.
On 2016/04/05 19:45:34, Mark Mentovai wrote:
> Committed patchset #2 (id:20001) manually as
> 46359276c8c72c56e4103c90be22bbfda32c942d (presubmit successful).

Great thanks, Mark!

Powered by Google App Engine
This is Rietveld 408576698