Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1864593002: PPC: Remove unnecessay file from v8.gyp (Closed)

Created:
4 years, 8 months ago by JaideepBajwa
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Remove unnecessay file from v8.gyp Since interface-descriptors-ppc.h is removed, so remove it from v8.gyp as well. R=machenbach@chromium.org,joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/6b1f75343c09ae0d7546eea8fbb26b7d2fbee649 Cr-Commit-Position: refs/heads/master@{#35276}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tools/gyp/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
JaideepBajwa
PTAL
4 years, 8 months ago (2016-04-05 17:34:37 UTC) #1
Michael Achenbach
lgtm
4 years, 8 months ago (2016-04-05 17:49:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864593002/1
4 years, 8 months ago (2016-04-05 17:56:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 18:29:02 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 18:30:02 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6b1f75343c09ae0d7546eea8fbb26b7d2fbee649
Cr-Commit-Position: refs/heads/master@{#35276}

Powered by Google App Engine
This is Rietveld 408576698