Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 1864583005: Update DownSampleImageFilter to sk_sp (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update to ToT #

Patch Set 3 : Fix fuzz #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M fuzz/FilterFuzz.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gm/testimagefilters.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M include/effects/SkTestImageFilters.h View 2 chunks +12 lines, -6 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkTestImageFilters.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864583005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864583005/20001
4 years, 8 months ago (2016-04-05 22:49:45 UTC) #3
robertphillips
4 years, 8 months ago (2016-04-05 22:50:08 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/1731)
4 years, 8 months ago (2016-04-05 22:51:20 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864583005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864583005/40001
4 years, 8 months ago (2016-04-05 23:06:26 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-05 23:18:17 UTC) #12
f(malita)
lgtm
4 years, 8 months ago (2016-04-06 14:35:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864583005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864583005/40001
4 years, 8 months ago (2016-04-06 14:43:00 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 14:44:04 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/fc0f44a5f0a4001b894ecf357bbed2a0d93058c1

Powered by Google App Engine
This is Rietveld 408576698