Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1864543005: docs: migrate another piece of the html android build instructions (Closed)

Created:
4 years, 8 months ago by tfarina
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

docs: migrate another piece of the html android build instructions This patch adds the text until the "Plug in your Android device" section. BUG=None TEST=None R=newt@chromium.org,dpranke@chromium.org Committed: https://crrev.com/ba2792faee4fc03c73b39c29dc322e86c4f3e9c9 Cr-Commit-Position: refs/heads/master@{#385768}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rm link that does not work #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -0 lines) Patch
M docs/android_build_instructions.md View 1 1 chunk +113 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
tfarina
4 years, 8 months ago (2016-04-06 18:55:54 UTC) #1
newt (away)
lgtm after comment https://codereview.chromium.org/1864543005/diff/1/docs/android_build_instructions.md File docs/android_build_instructions.md (right): https://codereview.chromium.org/1864543005/diff/1/docs/android_build_instructions.md#newcode122 docs/android_build_instructions.md:122: [symbol_level](https://code.google.com/p/chromium/codesearch#search/&q=file:build.*build.gn%20symbol_level&sq=package:chromium&type=cs) Does this link inside a ...
4 years, 8 months ago (2016-04-06 20:41:16 UTC) #2
Dirk Pranke
lgtm w/ newt's question addressed (I wouldn't really expect it to work, either).
4 years, 8 months ago (2016-04-06 22:00:56 UTC) #3
tfarina
https://codereview.chromium.org/1864543005/diff/1/docs/android_build_instructions.md File docs/android_build_instructions.md (right): https://codereview.chromium.org/1864543005/diff/1/docs/android_build_instructions.md#newcode122 docs/android_build_instructions.md:122: [symbol_level](https://code.google.com/p/chromium/codesearch#search/&q=file:build.*build.gn%20symbol_level&sq=package:chromium&type=cs) On 2016/04/06 20:41:16, newt (no new reviews. mostly) ...
4 years, 8 months ago (2016-04-07 15:01:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864543005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864543005/20001
4 years, 8 months ago (2016-04-07 15:01:49 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-07 15:50:56 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 15:52:57 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ba2792faee4fc03c73b39c29dc322e86c4f3e9c9
Cr-Commit-Position: refs/heads/master@{#385768}

Powered by Google App Engine
This is Rietveld 408576698