[FastTextAutosizer] Keep m_blocksForFingerprint and m_fingerprints in sync

Source/core/rendering/FastTextAutosizer.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 641 matching lines @@
 
     return false;
 }
 
 FastTextAutosizer::Cluster* FastTextAutosizer::currentCluster() const
 {
     ASSERT(!m_clusterStack.isEmpty());
     return m_clusterStack.last().get();
 }
 
+#ifndef NDEBUG
+bool FastTextAutosizer::FingerprintMapper::mapsAreConsistent()
+{
+    // For each fingerprint -> block mapping in m_blocksForFingerprint we should have an associated
+    // map from block -> fingerprint in m_fingerprints.
+    ReverseFingerprintMap::iterator end = m_blocksForFingerprint.end();
+    for (ReverseFingerprintMap::iterator fingerprintIt = m_blocksForFingerprint.begin(); fingerprintIt != end; ++fingerprintIt) {
+        Fingerprint fingerprint = fingerprintIt->key;
+        BlockSet* blocks = fingerprintIt->value.get();
+        for (BlockSet::iterator blockIt = blocks->begin(); blockIt != blocks->end(); ++blockIt) {
+            const RenderBlock* block = (*blockIt);
+            ASSERT(m_fingerprints.get(block) == fingerprint);
+        }
+    }
+
+    return true;

[skobes, 2014/03/05 04:12:22]

It's a bit silly to have a return value that is always true - just return void
and call it assertMapsAreConsistent.

[pdr., 2014/03/05 04:20:31]

Fair point. I was jumping through silly hoops to avoid #ifndef NDEBUG checks.

Fixed.

+}
+#endif
+
 void FastTextAutosizer::FingerprintMapper::add(const RenderObject* renderer, Fingerprint fingerprint)
 {
+    // Make sure to remove any existing fingerprint mapping for this renderer.
+    Fingerprint oldFingerprint = m_fingerprints.get(renderer);
+    if (oldFingerprint && renderer->isRenderBlock()) {
+        ReverseFingerprintMap::iterator blocksIter = m_blocksForFingerprint.find(oldFingerprint);
+        if (blocksIter != m_blocksForFingerprint.end())
+            blocksIter->value->remove(toRenderBlock(renderer));

[skobes, 2014/03/05 04:12:22]

I think I liked it better when this just called FingerprintMapper::remove.

If blocksIter->value is empty after this call, don't we want to remove it from
m_blocksForFingerprint?

[pdr., 2014/03/05 04:20:31]

Yeah, I agree. This will have one unnecessary hash lookup (we remove an entry
from m_fingerprints and immediately set it below) but I think it's worth it for
code maintainability.

Done.

+    }
+
     m_fingerprints.set(renderer, fingerprint);
+
+    ASSERT(mapsAreConsistent());
 }
 
 void FastTextAutosizer::FingerprintMapper::addTentativeClusterRoot(const RenderBlock* block, Fingerprint fingerprint)
 {
     add(block, fingerprint);
 
     ReverseFingerprintMap::AddResult addResult = m_blocksForFingerprint.add(fingerprint, PassOwnPtr<BlockSet>());
     if (addResult.isNewEntry)
         addResult.storedValue->value = adoptPtr(new BlockSet);
     addResult.storedValue->value->add(block);
+    ASSERT(mapsAreConsistent());
 }
 
 void FastTextAutosizer::FingerprintMapper::remove(const RenderObject* renderer)
 {
     Fingerprint fingerprint = m_fingerprints.take(renderer);
     if (!fingerprint || !renderer->isRenderBlock())
         return;
 
     ReverseFingerprintMap::iterator blocksIter = m_blocksForFingerprint.find(fingerprint);
     if (blocksIter == m_blocksForFingerprint.end())
         return;
 
     BlockSet& blocks = *blocksIter->value;
     blocks.remove(toRenderBlock(renderer));
     if (blocks.isEmpty())
         m_blocksForFingerprint.remove(blocksIter);
+    ASSERT(mapsAreConsistent());
 }
 
 FastTextAutosizer::Fingerprint FastTextAutosizer::FingerprintMapper::get(const RenderObject* renderer)
 {
     return m_fingerprints.get(renderer);
 }
 
 FastTextAutosizer::BlockSet& FastTextAutosizer::FingerprintMapper::getTentativeClusterRoots(Fingerprint fingerprint)
 {
     return *m_blocksForFingerprint.get(fingerprint);
@@ skipping 27 matching lines @@
         m_textAutosizer = 0;
 }
 
 FastTextAutosizer::LayoutScope::~LayoutScope()
 {
     if (m_textAutosizer)
         m_textAutosizer->endLayout(m_block);
 }
 
 } // namespace WebCore