Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1148)

Issue 18645002: Print to stdout when spending a long time downloading files (Closed)

Created:
7 years, 5 months ago by csharp
Modified:
7 years, 5 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, csharp+cc_chromium.org, vadimsh+cc_chromium.org, maruel+cc_chromium.org
Visibility:
Public.

Description

Print to stdout when spending a long time downloading files This must go to the stdout so that swarm or buildbot won't kill the test if it takes more than 10 minutes to download all the required files, which could occur if the machine has no cache. TBR=vadimsh@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=210001

Patch Set 1 #

Total comments: 2

Patch Set 2 : Responding to comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M run_isolated.py View 1 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
csharp
I stumble over this while looking into the hanging issue. I've haven't seen this in ...
7 years, 5 months ago (2013-07-03 15:04:47 UTC) #1
Vadim Sh.
On 2013/07/03 15:04:47, csharp wrote: > I stumble over this while looking into the hanging ...
7 years, 5 months ago (2013-07-03 15:16:26 UTC) #2
Vadim Sh.
One more thing.. https://codereview.chromium.org/18645002/diff/1/run_isolated.py File run_isolated.py (right): https://codereview.chromium.org/18645002/diff/1/run_isolated.py#newcode1779 run_isolated.py:1779: logging.info('%d files remaining...' % len(remaining)) And ...
7 years, 5 months ago (2013-07-03 15:29:50 UTC) #3
csharp
https://codereview.chromium.org/18645002/diff/1/run_isolated.py File run_isolated.py (right): https://codereview.chromium.org/18645002/diff/1/run_isolated.py#newcode1779 run_isolated.py:1779: logging.info('%d files remaining...' % len(remaining)) On 2013/07/03 15:29:50, Vadim ...
7 years, 5 months ago (2013-07-03 17:27:10 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 5 months ago (2013-07-03 17:27:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/18645002/5001
7 years, 5 months ago (2013-07-03 17:27:56 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-03 17:29:28 UTC) #7
Message was sent while issue was closed.
Change committed as 210001

Powered by Google App Engine
This is Rietveld 408576698