Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1864493002: Adding tall content may require insertion of more than one additional column row. (Closed)

Created:
4 years, 8 months ago by mstensho (USE GERRIT)
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding tall content may require insertion of more than one additional column row. There's no guarantee that adding just one column row has created enough columns to flow the content into. So add as many as we need. Committed: https://crrev.com/6e761f2e50c864027bf4bb0b87be2651834552bf Cr-Commit-Position: refs/heads/master@{#385226}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/nested-with-tall-block.html View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/nested-with-tall-block-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 chunk +19 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mstensho (USE GERRIT)
4 years, 8 months ago (2016-04-05 15:31:59 UTC) #2
leviw_travelin_and_unemployed
do { LGTM; } while(true)!
4 years, 8 months ago (2016-04-05 18:13:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864493002/1
4 years, 8 months ago (2016-04-05 18:13:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 18:19:42 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6e761f2e50c864027bf4bb0b87be2651834552bf Cr-Commit-Position: refs/heads/master@{#385226}
4 years, 8 months ago (2016-04-05 18:20:56 UTC) #8
mstensho (USE GERRIT)
4 years, 8 months ago (2016-04-15 12:55:21 UTC) #9
Message was sent while issue was closed.
This turned out to fix bug 584217.

Powered by Google App Engine
This is Rietveld 408576698