Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: media/audio/mac/audio_low_latency_input_mac_unittest.cc

Issue 1864483002: Forward output glitch information from stream WebRTC log (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/mac/audio_low_latency_input_mac.cc ('k') | media/audio/mac/audio_manager_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/mac/audio_low_latency_input_mac_unittest.cc
diff --git a/media/audio/mac/audio_low_latency_input_mac_unittest.cc b/media/audio/mac/audio_low_latency_input_mac_unittest.cc
index bb40aad413f25c5859733d2bb87c4ca0b65d0c12..38e0dbd849a9bfe7ae80290a28e09cbcd066c408 100644
--- a/media/audio/mac/audio_low_latency_input_mac_unittest.cc
+++ b/media/audio/mac/audio_low_latency_input_mac_unittest.cc
@@ -134,7 +134,8 @@ class MacAudioInputTest : public testing::Test {
AudioInputStream* ais = audio_manager_->MakeAudioInputStream(
AudioParameters(AudioParameters::AUDIO_PCM_LOW_LATENCY,
CHANNEL_LAYOUT_STEREO, fs, 16, samples_per_packet),
- AudioDeviceDescription::kDefaultDeviceId);
+ AudioDeviceDescription::kDefaultDeviceId,
+ base::Bind(&MacAudioInputTest::OnLogMessage, base::Unretained(this)));
EXPECT_TRUE(ais);
return ais;
}
@@ -147,13 +148,17 @@ class MacAudioInputTest : public testing::Test {
AudioInputStream* ais = audio_manager_->MakeAudioInputStream(
AudioParameters(AudioParameters::AUDIO_PCM_LOW_LATENCY, channel_layout,
fs, 16, samples_per_packet),
- AudioDeviceDescription::kDefaultDeviceId);
+ AudioDeviceDescription::kDefaultDeviceId,
+ base::Bind(&MacAudioInputTest::OnLogMessage, base::Unretained(this)));
EXPECT_TRUE(ais);
return ais;
}
+ void OnLogMessage(const std::string& message) { log_message_ = message; }
+
base::MessageLoop message_loop_;
ScopedAudioManagerPtr audio_manager_;
+ std::string log_message_;
};
// Test Create(), Close().
@@ -216,6 +221,8 @@ TEST_F(MacAudioInputTest, AUAudioInputStreamVerifyMonoRecording) {
run_loop.Run();
ais->Stop();
ais->Close();
+
+ EXPECT_FALSE(log_message_.empty());
}
// Verify that recording starts and stops correctly in mono using mocked sink.
@@ -249,6 +256,8 @@ TEST_F(MacAudioInputTest, AUAudioInputStreamVerifyStereoRecording) {
run_loop.Run();
ais->Stop();
ais->Close();
+
+ EXPECT_FALSE(log_message_.empty());
}
// This test is intended for manual tests and should only be enabled
« no previous file with comments | « media/audio/mac/audio_low_latency_input_mac.cc ('k') | media/audio/mac/audio_manager_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698