Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Unified Diff: media/audio/pulse/audio_manager_pulse.cc

Issue 1864483002: Forward output glitch information from stream WebRTC log (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Finished up for review. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/pulse/audio_manager_pulse.cc
diff --git a/media/audio/pulse/audio_manager_pulse.cc b/media/audio/pulse/audio_manager_pulse.cc
index 4ec100e26f3ec07fc4fd8bac437834c70e9b9b12..7795fad44a156047aaf44851fede801f455dbe28 100644
--- a/media/audio/pulse/audio_manager_pulse.cc
+++ b/media/audio/pulse/audio_manager_pulse.cc
@@ -144,16 +144,19 @@ AudioParameters AudioManagerPulse::GetInputStreamParameters(
AudioOutputStream* AudioManagerPulse::MakeLinearOutputStream(
const AudioParameters& params) {
DCHECK_EQ(AudioParameters::AUDIO_PCM_LINEAR, params.format());
- return MakeOutputStream(params, AudioDeviceDescription::kDefaultDeviceId);
+ return MakeOutputStream(params, AudioDeviceDescription::kDefaultDeviceId,
+ StatisticsCallback());
}
AudioOutputStream* AudioManagerPulse::MakeLowLatencyOutputStream(
const AudioParameters& params,
- const std::string& device_id) {
+ const std::string& device_id,
+ const StatisticsCallback& statistics_callback) {
DCHECK_EQ(AudioParameters::AUDIO_PCM_LOW_LATENCY, params.format());
- return MakeOutputStream(params, device_id.empty()
- ? AudioDeviceDescription::kDefaultDeviceId
- : device_id);
+ return MakeOutputStream(
+ params,
+ device_id.empty() ? AudioDeviceDescription::kDefaultDeviceId : device_id,
+ statistics_callback);
}
AudioInputStream* AudioManagerPulse::MakeLinearInputStream(
@@ -196,7 +199,8 @@ AudioParameters AudioManagerPulse::GetPreferredOutputStreamParameters(
AudioOutputStream* AudioManagerPulse::MakeOutputStream(
const AudioParameters& params,
- const std::string& device_id) {
+ const std::string& device_id,
+ const StatisticsCallback& statistics_callback) {
DCHECK(!device_id.empty());
return new PulseAudioOutputStream(params, device_id, this);
}

Powered by Google App Engine
This is Rietveld 408576698