media/audio/cras/audio_manager_cras.cc - Issue 1864483002: Forward output glitch information from stream WebRTC log

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/cras/audio_manager_cras.cc

Issue 1864483002: Forward output glitch information from stream WebRTC log (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finished up for review. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/audio/audio_output_dispatcher_impl.cc ('K') | « media/audio/cras/audio_manager_cras.h ('k') | media/audio/fake_audio_log_factory.cc » ('j') | media/audio/mac/audio_manager_mac.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/audio/cras/audio_manager_cras.cc

diff --git a/media/audio/cras/audio_manager_cras.cc b/media/audio/cras/audio_manager_cras.cc

index c18cd67910865fb143cd15283660c3a32ec04623..142ba118a25766b77bd02cd36a1b461e6bebd987 100644

--- a/media/audio/cras/audio_manager_cras.cc

+++ b/media/audio/cras/audio_manager_cras.cc

@@ -226,7 +226,8 @@ AudioOutputStream* AudioManagerCras::MakeLinearOutputStream(

AudioOutputStream* AudioManagerCras::MakeLowLatencyOutputStream(

const AudioParameters& params,

- const std::string& device_id) {

+ const std::string& device_id,

+ const StatisticsCallback& statistics_callback) {

DLOG_IF(ERROR, !device_id.empty()) << "Not implemented!";

DCHECK_EQ(AudioParameters::AUDIO_PCM_LOW_LATENCY, params.format());

// TODO(dgreid): Open the correct input device for unified IO.

« media/audio/audio_output_dispatcher_impl.cc ('K') | « media/audio/cras/audio_manager_cras.h ('k') | media/audio/fake_audio_log_factory.cc » ('j') | media/audio/mac/audio_manager_mac.cc » ('J')