Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2000)

Unified Diff: media/audio/audio_manager_base.cc

Issue 1864483002: Forward output glitch information from stream WebRTC log (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Finished up for review. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_manager_base.cc
diff --git a/media/audio/audio_manager_base.cc b/media/audio/audio_manager_base.cc
index 47279886b0cb159ea0fee6571795dcf59d78b50f..4232f579ccf808c447d3a6744a39f6a3e8c1beae 100644
--- a/media/audio/audio_manager_base.cc
+++ b/media/audio/audio_manager_base.cc
@@ -105,7 +105,8 @@ base::string16 AudioManagerBase::GetAudioInputDeviceModel() {
AudioOutputStream* AudioManagerBase::MakeAudioOutputStream(
const AudioParameters& params,
- const std::string& device_id) {
+ const std::string& device_id,
+ const StatisticsCallback& statistics_callback) {
// TODO(miu): Fix ~50 call points across several unit test modules to call
// this method on the audio thread, then uncomment the following:
// DCHECK(GetTaskRunner()->BelongsToCurrentThread());
@@ -135,7 +136,8 @@ AudioOutputStream* AudioManagerBase::MakeAudioOutputStream(
stream = MakeLinearOutputStream(params);
o1ka 2016/05/18 14:00:16 Why there is no logging for linear?
Henrik Grunell 2016/05/23 17:13:55 I've added linear as well now.
break;
case AudioParameters::AUDIO_PCM_LOW_LATENCY:
- stream = MakeLowLatencyOutputStream(params, device_id);
+ stream =
+ MakeLowLatencyOutputStream(params, device_id, statistics_callback);
break;
case AudioParameters::AUDIO_FAKE:
stream = FakeAudioOutputStream::MakeFakeStream(this, params);

Powered by Google App Engine
This is Rietveld 408576698