Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: media/audio/audio_manager.h

Issue 1864483002: Forward output glitch information from stream WebRTC log (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Finished up for review. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_manager.h
diff --git a/media/audio/audio_manager.h b/media/audio/audio_manager.h
index 90dba8ade735804682740ff57f852fe171e3c78c..585ae9c8766ae0ac58953e2fe53bc3f16a70bd4e 100644
--- a/media/audio/audio_manager.h
+++ b/media/audio/audio_manager.h
@@ -8,6 +8,7 @@
#include <memory>
#include <string>
+#include "base/callback.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "base/sequenced_task_runner_helpers.h"
@@ -132,6 +133,11 @@ class MEDIA_EXPORT AudioManager {
// Audio worker thread (see GetWorkerTaskRunner()).
virtual void GetAudioOutputDeviceNames(AudioDeviceNames* device_names) = 0;
+ // Log callback used for sending log messages from a stream to the object
+ // that manages the stream.
+ using StatisticsCallback =
DaleCurtis 2016/05/19 20:34:37 Again, this should just be a base::Callback(string
Henrik Grunell 2016/05/23 17:13:54 Done.
+ base::Callback<void(AudioOutputStream*, const std::string&, int)>;
+
// Factory for all the supported stream formats. |params| defines parameters
// of the audio stream to be created.
//
@@ -155,7 +161,8 @@ class MEDIA_EXPORT AudioManager {
// Do not free the returned AudioOutputStream. It is owned by AudioManager.
virtual AudioOutputStream* MakeAudioOutputStream(
const AudioParameters& params,
- const std::string& device_id) = 0;
+ const std::string& device_id,
+ const StatisticsCallback& statistics_callback) = 0;
// Creates new audio output proxy. A proxy implements
// AudioOutputStream interface, but unlike regular output stream

Powered by Google App Engine
This is Rietveld 408576698