Forward output glitch information from stream WebRTC log

media/audio/audio_logging.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_AUDIO_AUDIO_LOGGING_H_
 #define MEDIA_AUDIO_AUDIO_LOGGING_H_
 
 #include <memory>
 #include <string>
 
 
 namespace media {
+
 class AudioParameters;
 
 // AudioLog logs state information about an active audio component.  Each method
 // takes a |component_id| along with method specific information.  Its methods
 // are safe to call from any thread.
 class AudioLog {
  public:
   virtual ~AudioLog() {}
 
   // Called when an audio component is created.  |params| are the parameters of
@@ skipping 18 matching lines @@
   // Called when an audio component encounters an error.
   virtual void OnError(int component_id) = 0;
 
   // Called when an audio component changes volume.  |volume| is the new volume.
   virtual void OnSetVolume(int component_id, double volume) = 0;
 
   // Called when an audio component switches output device. |device_id| is the
   // new audio output device.
   virtual void OnSwitchOutputDevice(int component_id,
                                     const std::string& device_id) = 0;
+
+  // Stats reporting.
+  virtual void OnStatistics(int component_id,

[DaleCurtis, 2016/05/19 20:34:37]

It seems this should just be OnStatistics(component_id, string)? Otherwise
you're enforcing all statistics to be of integer type.

[Henrik Grunell, 2016/05/23 17:13:54]

I did consider just using a string (and call it OnMessage() or so). My idea with
string + value was to allow media-internals to track the stats in the future and
int would do for most cases. We could of course change that if we want to add
stats to media-internals later.

If we only pass a string we're not bound to use the AudioLog, so for input we
can just use the existing AudioInputCOntroller::EventHandler::OnLog() which
would simplify a bit there.

I'm fine with either, actually I lean towards just a string and change the name
to AudioLog::OnMessage(), for using existing path on input and avoid adding
extra code.

I've changed to string only.

+                            const std::string& name,
+                            int value) = 0;
 };
 
 // AudioLogFactory dispenses AudioLog instances to owning classes for tracking
 // AudioComponent behavior.  All AudioComponents have the concept of an owning
 // class:
 //
 //    - AudioInputRendererHost for AudioInputController
 //    - AudioRendererHost for AudioOutputController
 //    - AudioOutputDispatcherImpl for AudioOutputStream
 //
@@ skipping 18 matching lines @@
   virtual std::unique_ptr<AudioLog> CreateAudioLog(
       AudioComponent component) = 0;
 
  protected:
   virtual ~AudioLogFactory() {}
 };
 
 }  // namespace media
 
 #endif  // MEDIA_AUDIO_AUDIO_LOGGING_H_