Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 1864463002: Add Emoji properties (Closed)

Created:
4 years, 8 months ago by jungshik at Google
Modified:
4 years, 8 months ago
Reviewers:
drott
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add Emoji properties Cherry pick http://bugs.icu-project.org/trac/changeset/38183 to add the support for Emoji properties. This will be followed by a Blink change to use the API. ( https://codereview.chromium.org/1856353002 ) There's no need to rebuild ICU data because Unicode character properties are hard-coded in the C++ source files that are patched by the cherry-pick above. source/data/in/{pnames,uprops}.icu are updated just for the record, but they're not actually used. The same is true of files in source/data/unidata. BUG=583378 TEST=None TBR=drott Committed: https://chromium.googlesource.com/chromium/deps/icu/+/c291cde264469b20ca969ce8832088acb21e0c48

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10767 lines, -3108 lines) Patch
M README.chromium View 1 chunk +8 lines, -0 lines 0 comments Download
A patches/emoji_props.patch View 1 chunk +7535 lines, -0 lines 0 comments Download
M source/common/propname_data.h View 4 chunks +802 lines, -796 lines 0 comments Download
M source/common/ubidi_props_data.h View 1 chunk +1 line, -1 line 0 comments Download
M source/common/ucase_props_data.h View 1 chunk +1 line, -1 line 0 comments Download
M source/common/uchar_props_data.h View 10 chunks +1777 lines, -1755 lines 0 comments Download
M source/common/unicode/uchar.h View 2 chunks +30 lines, -2 lines 0 comments Download
M source/common/uprops.h View 2 chunks +10 lines, -2 lines 0 comments Download
M source/common/uprops.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M source/data/in/pnames.icu View Binary file 0 comments Download
M source/data/in/uprops.icu View Binary file 0 comments Download
M source/data/unidata/changes.txt View 2 chunks +30 lines, -1 line 0 comments Download
M source/data/unidata/norm2/nfc.txt View 1 chunk +1 line, -1 line 0 comments Download
M source/data/unidata/norm2/nfkc.txt View 1 chunk +1 line, -1 line 0 comments Download
M source/data/unidata/norm2/nfkc_cf.txt View 1 chunk +1 line, -1 line 0 comments Download
M source/data/unidata/ppucd.txt View 75 chunks +545 lines, -541 lines 0 comments Download
M source/test/intltest/ucdtest.h View 2 chunks +2 lines, -2 lines 0 comments Download
M source/test/intltest/ucdtest.cpp View 3 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
jungshik at Google
4 years, 8 months ago (2016-04-05 10:18:27 UTC) #4
jungshik at Google
Committed patchset #1 (id:1) manually as c291cde264469b20ca969ce8832088acb21e0c48 (presubmit successful).
4 years, 8 months ago (2016-04-05 10:19:58 UTC) #6
drott
4 years, 8 months ago (2016-04-05 20:01:15 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698