Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1864433003: [heap] Old generation limit is based on capacity. (Closed)

Created:
4 years, 8 months ago by Hannes Payer (out of office)
Modified:
4 years, 8 months ago
Reviewers:
Michael Lippautz
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Old generation limit is based on capacity. BUG=chromium:600258 LOG=n Committed: https://crrev.com/d16c3825fbd91997552b1c9251ec5a436fe80e8a Cr-Commit-Position: refs/heads/master@{#35296}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -24 lines) Patch
M src/heap/heap.h View 2 chunks +5 lines, -4 lines 0 comments Download
M src/heap/heap.cc View 1 1 chunk +8 lines, -2 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +2 lines, -15 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Hannes Payer (out of office)
4 years, 8 months ago (2016-04-05 11:35:51 UTC) #2
Michael Lippautz
lgtm
4 years, 8 months ago (2016-04-05 11:45:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864433003/1
4 years, 8 months ago (2016-04-05 12:47:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/17777)
4 years, 8 months ago (2016-04-05 13:10:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864433003/1
4 years, 8 months ago (2016-04-06 08:57:55 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/5419) v8_win64_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 8 months ago (2016-04-06 09:21:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864433003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864433003/20001
4 years, 8 months ago (2016-04-06 11:13:57 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-06 11:52:27 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 11:53:18 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d16c3825fbd91997552b1c9251ec5a436fe80e8a
Cr-Commit-Position: refs/heads/master@{#35296}

Powered by Google App Engine
This is Rietveld 408576698