chrome/chrome_tests_unit.gypi - Issue 1864423002: ToolbarButton: Reset menu runner before deleting its menu's delegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_tests_unit.gypi

Issue 1864423002: ToolbarButton: Reset menu runner before deleting its menu's delegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tests working, but I do not like what the test suite makes me do Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_tests_unit.gypi

diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi

index 95042ca4c5482d0b799440513bc14d1a518bf680..46d0d88de073018ff710103ed88563444e24375e 100644

--- a/chrome/chrome_tests_unit.gypi

+++ b/chrome/chrome_tests_unit.gypi

@@ -1383,6 +1383,7 @@

'browser/ui/views/toolbar/reload_button_unittest.cc',

'browser/ui/views/toolbar/toolbar_action_view_unittest.cc',

'browser/ui/views/toolbar/toolbar_actions_bar_bubble_views_unittest.cc',

+ 'browser/ui/views/toolbar/toolbar_button_unittest.cc',

'browser/ui/views/translate/translate_bubble_view_unittest.cc',

'browser/ui/views/validation_message_bubble_delegate_unittest.cc',

« chrome/browser/ui/views/toolbar/toolbar_button_unittest.cc ('K') | « chrome/browser/ui/views/toolbar/toolbar_button_unittest.cc ('k') | no next file » | no next file with comments »