chrome/browser/ui/views/toolbar/toolbar_button.h - Issue 1864423002: ToolbarButton: Reset menu runner before deleting its menu's delegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_button.h

Issue 1864423002: ToolbarButton: Reset menu runner before deleting its menu's delegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tests working, but I do not like what the test suite makes me do Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/toolbar/toolbar_button.h

diff --git a/chrome/browser/ui/views/toolbar/toolbar_button.h b/chrome/browser/ui/views/toolbar/toolbar_button.h

index 11393df8efe1376ddc46d1f7bedc420ae1570731..b4c94cd6d7b6b4f01b56ea6f5bc052673fb80076 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_button.h

+++ b/chrome/browser/ui/views/toolbar/toolbar_button.h

@@ -14,6 +14,10 @@

class Profile;

+namespace test {

+class ToolbarButtonTestApi;

namespace ui {

class MenuModel;

}

@@ -69,6 +73,8 @@ class ToolbarButton : public views::LabelButton,

virtual void ShowDropDownMenu(ui::MenuSourceType source_type);

private:

+ friend test::ToolbarButtonTestApi;

// Callback for MenuModelAdapter.

void OnMenuClosed();

« no previous file with comments | « no previous file | chrome/browser/ui/views/toolbar/toolbar_button.cc » ('j') | chrome/browser/ui/views/toolbar/toolbar_button_unittest.cc » ('J')