[NaCl SDK] Upate atomic ops in nacl_io

native_client_sdk/src/libraries/sdk_util/simple_lock.h

+/* Copyright (c) 2013 The Chromium Authors. All rights reserved.
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+#ifndef LIBRARIES_SDK_UTIL_SIMPLE_LOCK_H_
+#define LIBRARIES_SDK_UTIL_SIMPLE_LOCK_H_
+
+#include "pthread.h"
+#include "sdk_util/macros.h"
+
+class AutoLock;

[binji, 2013/07/12 00:51:23]

not necessary

[noelallen1, 2013/07/12 23:18:47]

Done.

+
+/*
+ * SimpleLock
+ *
+ * A pthread mutex object, with automatic initialization and destruction.
+ * Should be used with AutoLock where possible.
+ */
+class SimpleLock {

[binji, 2013/07/12 00:51:23]

Why SimpleLock? Maybe just Lock? 

[noelallen1, 2013/07/12 23:18:47]

Less likely to collide with a name.

[binji, 2013/07/13 00:16:47]

OK, can we change it to Lock after I add namespaces?

+ public:
+  SimpleLock() {
+    pthread_mutex_init(&lock_, NULL);
+  }
+
+  ~SimpleLock() {
+    pthread_mutex_destroy(&lock_);
+  }
+
+  operator pthread_mutex_t*() const { return &lock_; }

[binji, 2013/07/12 00:51:23]

We should just have a function for this, rather than an implicit conversion.

[noelallen1, 2013/07/12 23:18:47]

Done.

+
+ private:
+  mutable pthread_mutex_t lock_;
+  friend class AutoLock;
+
+  DISALLOW_COPY_AND_ASSIGN(SimpleLock);
+};
+
+#endif  // LIBRARIES_SDK_UTIL_SIMPLE_LOCK_H_
+