Support for TakeScreenshot in cros_platform.

Support for TakeScreenshot in cros_platform.

BUG=chromium:601239
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/2f922d2c7b8ca1f657aa19ff8b3571646f501ad6

[achuithb, 2016-04-06 23:12:24]

The CQ bit was checked by achuith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 23:12:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1864383002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1864383002/1

[achuithb, 2016-04-06 23:13:13]

achuith@chromium.org changed reviewers:
+ nednguyen@google.com

[achuithb, 2016-04-06 23:13:13]

Please take a look Ned

[nednguyen, 2016-04-06 23:20:20]

lgtm with nits

Note that telemetry capture screenshot on failure & upload to cloud storage.

However, it only upload to cloud storage if you run it with "--upload-results"
flag. So you may want to update cros bot recipe to make this useful.

https://codereview.chromium.org/1864383002/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/platform/cros_platform_backend.py (right):

https://codereview.chromium.org/1864383002/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/platform/cros_platform_backend.py:175:
self._cri.TakeScreenshot(file_path)
this return True if it's believed the attempt succeeded.

[commit-bot: I haz the power, 2016-04-06 23:27:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 23:27:26]

Dry run: This issue passed the CQ dry run.

[achuithb, 2016-04-28 03:08:48]

Patchset #2 (id:20001) has been deleted

[achuithb, 2016-04-28 03:08:56]

The CQ bit was checked by achuith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-28 03:09:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1864383002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1864383002/40001

[achuithb, 2016-04-28 03:09:24]

Ned, could you please take another look?

[commit-bot: I haz the power, 2016-04-28 03:29:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 03:29:50]

Dry run: This issue passed the CQ dry run.

[nednguyen, 2016-04-28 03:36:01]

https://codereview.chromium.org/1864383002/diff/40001/telemetry/telemetry/int...
File telemetry/telemetry/internal/platform/cros_platform_backend.py (right):

https://codereview.chromium.org/1864383002/diff/40001/telemetry/telemetry/int...
telemetry/telemetry/internal/platform/cros_platform_backend.py:175:
self._cri.TakeScreenshot(file_path)
ping?

[achuithb, 2016-04-29 00:30:58]

ptal

https://codereview.chromium.org/1864383002/diff/40001/telemetry/telemetry/int...
File telemetry/telemetry/internal/platform/cros_platform_backend.py (right):

https://codereview.chromium.org/1864383002/diff/40001/telemetry/telemetry/int...
telemetry/telemetry/internal/platform/cros_platform_backend.py:175:
self._cri.TakeScreenshot(file_path)
On 2016/04/28 03:36:01, nednguyen (ooo til 5-4) wrote:
> ping?

Done.

[achuithb, 2016-04-29 00:31:03]

The CQ bit was checked by achuith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 00:31:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1864383002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1864383002/60001

[nednguyen, 2016-04-29 00:32:32]

lgtm

[achuithb, 2016-04-29 00:52:10]

On 2016/04/29 00:32:32, nednguyen (ooo til 5-4) wrote:
> lgtm

ty

[commit-bot: I haz the power, 2016-04-29 00:53:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 00:53:27]

Dry run: This issue passed the CQ dry run.

[achuithb, 2016-05-03 17:54:06]

The CQ bit was checked by achuith@chromium.org

[commit-bot: I haz the power, 2016-05-03 17:54:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1864383002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1864383002/60001

[commit-bot: I haz the power, 2016-05-03 18:15:24]

Description was changed from

==========
Support for TakeScreenshot in cros_platform.

BUG=chromium:601239
==========

to

==========
Support for TakeScreenshot in cros_platform.

BUG=chromium:601239

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-05-03 18:15:25]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...