Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Side by Side Diff: base/synchronization/lock_impl_win.cc

Issue 1864323002: Migrate from CRITICAL_SECTION to SRWLOCK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cv
Patch Set: Update Comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/synchronization/lock_impl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/synchronization/lock_impl.h" 5 #include "base/synchronization/lock_impl.h"
6 6
7 namespace base { 7 namespace base {
8 namespace internal { 8 namespace internal {
9 9
10 LockImpl::LockImpl() { 10 LockImpl::LockImpl() : native_handle_(SRWLOCK_INIT) {}
11 // The second parameter is the spin count, for short-held locks it avoid the
12 // contending thread from going to sleep which helps performance greatly.
13 ::InitializeCriticalSectionAndSpinCount(&native_handle_, 2000);
14 }
15 11
16 LockImpl::~LockImpl() { 12 LockImpl::~LockImpl() = default;
17 ::DeleteCriticalSection(&native_handle_);
18 }
19 13
20 bool LockImpl::Try() { 14 bool LockImpl::Try() {
21 if (::TryEnterCriticalSection(&native_handle_) != FALSE) { 15 return !!::TryAcquireSRWLockExclusive(&native_handle_);
22 return true;
23 }
24 return false;
25 } 16 }
26 17
27 void LockImpl::Lock() { 18 void LockImpl::Lock() {
28 ::EnterCriticalSection(&native_handle_); 19 ::AcquireSRWLockExclusive(&native_handle_);
29 } 20 }
30 21
31 void LockImpl::Unlock() { 22 void LockImpl::Unlock() {
32 ::LeaveCriticalSection(&native_handle_); 23 ::ReleaseSRWLockExclusive(&native_handle_);
33 } 24 }
34 25
35 } // namespace internal 26 } // namespace internal
36 } // namespace base 27 } // namespace base
OLDNEW
« no previous file with comments | « base/synchronization/lock_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698